This repository was archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
Google compute engine load balancing support for stratos #419
Open
asankasanjaya
wants to merge
224
commits into
apache:master
Choose a base branch
from
asankasanjaya:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 212 commits
Commits
Show all changes
224 commits
Select commit
Hold shift + click to select a range
c8ea6fa
adding gce-extension files
asankasan 14676ec
adding gce-extension files
asankasan e2fa056
adding gce-extension files
asankasan 11f114a
Merge branch 'master' of https://github.com/apache/stratos
asankasan da86337
adding a test method
asankasan b536600
fixing zone name error
asankasan a109bc3
adding create target pool method
asankasan 410927b
adding create target pool method
asankasan 3553eae
adding create target pool method
asankasan 1b1d313
adding create target pool method
asankasan 4a296f5
adding create target pool method
asankasan 59713f6
adding create target pool method
asankasan 6f036e0
adding create target pool method
asankasan df21f52
adding create target pool method
asankasan 658aaf1
adding create target pool method
asankasan 41574cd
adding create target pool method
asankasan 5ce548c
adding create target pool method
asankasan 30ce224
adding create target pool method
asankasan b987c45
adding create target pool method
asankasan 4f0b334
adding create target pool method
asankasan c3dc11b
adding create target pool method
asankasan 88df929
adding create target pool method
asankasan 9cee960
adding create target pool method
asankasan e12036e
adding create target pool method
asankasan 6457e31
changes in gce operations class
asankasan 8e24879
changes in gce operations class
asankasan 8f11bf0
changes in gce operations class
asankasan 7a4033d
changes in gce operations class
asankasan 0d345e7
changes in gce operations class
asankasan 1dd8cd1
changes in gce operations class
asankasan 8f6e2dc
changes in gce operations class
asankasan 6f1ba45
changes in gce operations class
asankasan 6cdde95
changes in gce operations class
asankasan 0a543d0
changes in gce operations class
asankasan a45c168
changes in gce operations class
asankasan f01b6ce
changes in gce operations class
asankasan dbe82ed
changes in gce operations class
asankasan 38f840f
changes in gce operations class
asankasan 3f05f40
changes in gce operations class
asankasan 19d93c0
changes in gce operations class
asankasan 28e5d6b
changes in gce operations class
asankasan f98ad9e
changes in gce operations class
asankasan d846b76
changes in gce operations class
asankasan eb7aaa8
changes in gce operations class
asankasan 70d3411
changes in gce operations class
asankasan ad88760
changes in gce operations class
asankasan 4c0556f
Adding constance and context classes
asankasan 8c3f0fd
adding logic for if cepstatpublisher enabled
asankasan 5a60af6
adding logic for if cepstatpublisher enabled
asankasan 70cff79
adding logic for if cepstatpublisher enabled
asankasan a0faaed
adding logic for if cepstatpublisher enabled
asankasan 2287952
adding logic for if cepstatpublisher enabled
asankasan 9f01cfe
testing configure method
asankasan 8917163
testing configure method
asankasan 503d5b9
adding logic for load balancer configuration
asankasan 03429b8
adding logic for load balancer configuration
asankasan dc0beea
adding logic for load balancer configuration
asankasan 14cb180
adding logic for load balancer configuration
asankasan fd33963
adding logic for load balancer configuration
asankasan 939cde8
adding logic for load balancer configuration
asankasan 8ade314
adding logic for load balancer configuration
asankasan d449739
adding logic for load balancer configuration
asankasan 57285d4
adding logic for load balancer configuration
asankasan 64c4223
adding logic for load balancer configuration
asankasan 3eeb140
adding code for start method and configure method
asankasan 2373ffc
adding code for start method and configure method
asankasan 8d598e6
adding code for start method and configure method
asankasan 18538cf
adding code for stop method and configure method
asankasan 4e58e24
Remove hard-coded values and reading from configuration
asankasan ce5bfc1
fixing error in project name
asankasan 230cc2f
fixing error in data store directory location
asankasan 66f83bb
fixing error in data store directory location
asankasan d2daffc
fixing bug
asankasan e6859f5
set waiting times for GCE api calls
asankasan a553955
set waiting times for GCE api calls
asankasan 4d6d1e7
set waiting times for GCE api calls
asankasan 416e688
adding health check operations
asankasan c0060fb
adding health check operations
asankasan a99ed70
adding health check operations
asankasan 33f63d7
adding health check operations
asankasan bffcb59
adding health check operations
asankasan e2ba1d8
adding health check operations
asankasan d440abe
adding a time out for operations
asankasan a760aac
adding a time out for operations
asankasan 3851b67
fix an issue in forwardingrulenamecreator method
asankasan 219e2ef
handling an exception in addInstancesToTargetPool method
asankasan 899167c
set a port range instead of using set of ports for forwarding rules
asankasan 85c5af5
set health checks to target pool
asankasan e2bcec6
set health checks to target pool
asankasan adc8f63
set health checks to target pool
asankasan 104c7a1
set health checks to target pool
asankasan 599aecb
set health checks to target pool
asankasan 6df323b
set health checks to target pool
asankasan 666b944
fixing bug in operation completion
asankasan 76af30c
fixing bug in operation completion
asankasan a86f624
fixing bug in operation completion
asankasan 5aec905
fixing bug in operation completion
asankasan 75667c5
fixing bug in operation completion
asankasan 5aff39d
fixing bug in operation completion
asankasan b70b2ef
fixing bug in operation completion
asankasan 5ac360d
fixing bug in operation completion
asankasan 2da76de
fixing bug in operation completion
asankasan 0656d91
fixing bug in operation completion
asankasan 7554133
fixing bug in operation completion
asankasan f47e19c
fixing bug in operation completion
asankasan dd351fa
fixing bug in operation complete
asankasan acea041
printing topology
asankasan 91c6f82
printing topology
asankasan b8629c0
printing topology
asankasan ca31ee7
testing member context
asankasan eae0215
testing member context
asankasan 3a7eb8d
Merge branch 'master' of https://github.com/apache/stratos
asankasan 753792b
testing member context
asankasan 25fd0d2
testing member context
asankasan 075207b
testing member context
asankasan 4cad6d8
set instance Id
asankasan 90fd4a5
set instance Id
asankasan 0c2b808
add instance to target pool
asankasan faea8da
add instance to target pool
asankasan 40913f5
add instance to target pool
asankasan 8e20c61
reformat code
asankasan 262d0f0
reformat code
asankasan 173571a
fixing heath check creation error
asankasan 1f244ab
fixing heath check creation error
asankasan dc3649b
implementing create forwarding rule method
asankasan d382b52
testing
asankasan 76efe36
implementing listening to topology and update it
asankasan 0c71fe9
implementing listening to topology and update it
asankasan f0e9970
implementing listening to topology and update it
asankasan c6eb780
implementing listening to topology and update it
asankasan a6ee0ab
implementing listening to topology and update it
asankasan 0a27206
implementing listening to topology and update it
asankasan f91e389
implementing listening to topology and update it
asankasan 2e196cf
changing the configure logic
asankasan 4e05e76
changing the configure logic
asankasan f048b6d
changing the configure logic
asankasan 3a126c0
changing the configure logic
asankasan 9e7b79d
Exception handling
asankasan 9286f44
Exception handling
asankasan 737e962
stop method implementation
asankasan 3e5637d
stop method implementation
asankasan 1c8cb0a
stop method implementation
asankasan c40d2d4
fixing a problem in LoadBalancerExtension class
asankasan d1b9d14
reverting changes in loadBalancerExtension class
asankasan ca7f68a
refining GCELoadBalancer class code
asankasan 691175c
Merge branch 'master' of https://github.com/apache/stratos
asankasan 846c4e2
remove instanceId field from instanceContext class
asankasan a3a98c0
removing member.setInstanceId from member initialized event in Topolo…
asankasan 32ae9b2
remove extra tab in LoadBalancerExtension class
asankasan 163b45f
adding removed "/n" in TopologyBuilder class
asankasan b3eb7bb
remove setting instanceId in member initialized event
asankasan 8b3d1f0
setting instanceId in member initialized event
asankasan fc2fa2c
Adding instance Id field again to instanceContext class
asankasan 1d529b7
revert changes in topologyBuilder class and InstanceContext class
asankasan 97baeaa
revert changes in topologyBuilder class and InstanceContext class
asankasan eb858b8
revert changes in topologyBuilder class and InstanceContext class
asankasan 82eaa2b
fixing an error in topology builder class
asankasan 9f44791
adding instaceID to message processor side
asankasan 9df565f
Adding a timeout for operation completion
asankasan 451e9a8
configuration read from a xml file-1
asankasan 515b543
configuration read from a xml file-1
asankasan 9404fe7
configuration read from a xml file-1
asankasan 3ac6c82
configuration read from a xml file-1
asankasan f487265
configuration read from a xml file-1
asankasan 9a150a9
configuration read from a xml file-fixing file path issue
asankasan f96e464
configuration read from a xml file-fixing file path issue
asankasan 116dae4
delaying configure method as a temporary solution for topology update…
asankasan d825622
let the configuration read from configuration file instead of system …
asankasan 52872e1
reformat the code and adding some comments
asankasan 138b1ea
resolving merge confilicts
asankasan 40584e8
Merge branch 'master' of https://github.com/apache/stratos
asankasan 8003da5
Merge branch 'master' of https://github.com/apache/stratos
asankasan 421212d
let the zone name detect from instance object-1
asankasan b4ae9ab
let the zone name detect from instance object-2
asankasan 4bb4394
let the zone name detect from instance object-2
asankasan 4059e3f
fixing a bug in getZoneNameFromInstanceId method
asankasan 8920d50
fixing a bug in getZoneNameFromInstanceId method
asankasan 5c73978
resolving the ConcurrentModificationException occurs when terminating…
asankasan 1d3c444
removing a to-do
asankasan 5ec1f0e
fixing a issue in getInstanceURLFromId method
asankasan e73dd7a
fix issues in GCEOperations.java class
asankasan 81d91d9
fixing an error related to log
asankasan 22f247a
adding some null checks for gceOperations.java
asankasan 9e1afb2
adding some null checks for gceOperations.java
asankasan 64f5455
adding some null checks for gceOperations.java
asankasan a21a032
removed the instance filter for testing purposes
asankasan 06c95a3
fixing an issue related to get instance URL when the member is termin…
asankasan f399054
log the error messages related to operation completion
asankasan 793891a
set health check interval
asankasan c99599e
set health check interval
asankasan e9f950e
set health check interval
asankasan 5fd3819
set health check interval
asankasan 017c8af
adding health check healthy threshold
asankasan 958263c
adding health check healthy threshold
asankasan 1cae53b
adding health check healthy threshold
asankasan 947f6fe
adding health check healthy threshold
asankasan 09be072
removing error logging in operation completion
asankasan 3ebd60c
configuration properties are validated
asankasan 2b7631b
added null checks for config parser
asankasan 6cbdebc
code reformatted
asankasan 2d2b9b9
adding license and notice
asankasan 2e130ed
change the logic for removing configuration for removed cluster in GC…
asankasan 78e325a
change the logic for removing configuration for removed cluster in GC…
asankasan 2d6ad4b
change the logic for removing configuration for removed cluster in GC…
asankasan cc8784a
change the logic for removing configuration for removed cluster in GC…
asankasan 0cf4074
exception handling
asankasan d5a68a7
Adding debug logs and reformat the code
asankasan 4bef72c
merge with apache stratos master branch
asankasan 75c3d15
changing the parent extension version
asankasan 92a20f9
solved some issues pointed out by sonarqube
asankasan 8a42670
get rid of throwing a runtime exception
asankasan 1250412
log error messages in log.error(object,throwable) format and change …
asankasan 4862b29
refine logs and fixing some issues mentioned by imesh
asankasan 2cf19a3
Preparing for next development iteration: updating pom version to 4.1…
ravihansa3000 e02e0ce
Read GCE API URL from configuration and make some other strings constant
asankasan 6e19dbb
fixing a log issue
asankasan 990ee9b
fixing merge conflicts
asankasan 19acc9e
fixing a concurrent modification exception issue
asankasan 619c973
removing some blank lines
asankasan 39b853b
adding a install.md file
asankasan a24999f
reformat code
asankasan eb56b83
add security folder
asankasan 6054640
create health checks using the application ports
asankasan 5ade51f
fixing an issue in health check name creation
asankasan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -440,6 +440,9 @@ private org.apache.stratos.load.balancer.common.domain.Member transformMember(Me | |
member.addPort(transformPort(port)); | ||
} | ||
} | ||
if(messagingMember.getInstanceId() != null){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Code is not formatted correctly. There should be a space between ) and { |
||
member.setInstanceId(messagingMember.getInstanceId()); | ||
} | ||
return member; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,140 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
~ Licensed to the Apache Software Foundation (ASF) under one | ||
~ or more contributor license agreements. See the NOTICE file | ||
~ distributed with this work for additional information | ||
~ regarding copyright ownership. The ASF licenses this file | ||
~ to you under the Apache License, Version 2.0 (the | ||
~ "License"); you may not use this file except in compliance | ||
~ with the License. You may obtain a copy of the License at | ||
~ | ||
~ http://www.apache.org/licenses/LICENSE-2.0 | ||
~ | ||
~ Unless required by applicable law or agreed to in writing, | ||
~ software distributed under the License is distributed on an | ||
~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
~ KIND, either express or implied. See the License for the | ||
~ specific language governing permissions and limitations | ||
~ under the License. | ||
--> | ||
|
||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
|
||
<parent> | ||
<groupId>org.apache.stratos</groupId> | ||
<artifactId>stratos-load-balancer-extensions</artifactId> | ||
<version>4.1.1-SNAPSHOT</version> | ||
</parent> | ||
|
||
<artifactId>org.apache.stratos.gce.extension</artifactId> | ||
<name>Apache Stratos - GCE Extension</name> | ||
<description>Apache Stratos GCE Extension for Load Balancing</description> | ||
|
||
<dependencies> | ||
<dependency> | ||
<groupId>org.slf4j</groupId> | ||
<artifactId>slf4j-log4j12</artifactId> | ||
<version>1.7.5</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.stratos</groupId> | ||
<artifactId>org.apache.stratos.common</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.stratos</groupId> | ||
<artifactId>org.apache.stratos.messaging</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.stratos</groupId> | ||
<artifactId>org.apache.stratos.load.balancer.extension.api</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>commons-io</groupId> | ||
<artifactId>commons-io</artifactId> | ||
<version>2.0</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.velocity</groupId> | ||
<artifactId>velocity</artifactId> | ||
<version>1.7</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.wso2.andes.wso2</groupId> | ||
<artifactId>andes-client</artifactId> | ||
<version>0.13.wso2v8</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.http-client</groupId> | ||
<artifactId>google-http-client-jackson2</artifactId> | ||
<version>${project.http.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.oauth-client</groupId> | ||
<artifactId>google-oauth-client-jetty</artifactId> | ||
<version>${project.oauth.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.apis</groupId> | ||
<artifactId>google-api-services-compute</artifactId> | ||
<version>v1-rev27-1.19.0</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.stratos</groupId> | ||
<artifactId>org.apache.stratos.cloud.controller</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.ws.commons.axiom.wso2</groupId> | ||
<artifactId>axiom</artifactId> | ||
<version>1.2.11.wso2v4</version> | ||
</dependency> | ||
</dependencies> | ||
|
||
<properties> | ||
<project.http.version>1.19.0</project.http.version> | ||
<project.oauth.version>1.19.0</project.oauth.version> | ||
</properties> | ||
|
||
<build> | ||
<plugins> | ||
<plugin> | ||
<artifactId>maven-assembly-plugin</artifactId> | ||
<configuration> | ||
<descriptors> | ||
<descriptor>src/main/assembly/bin.xml</descriptor> | ||
</descriptors> | ||
<archiverConfig> | ||
<fileMode>420</fileMode> | ||
<directoryMode>493</directoryMode> | ||
<defaultDirectoryMode>493</defaultDirectoryMode> | ||
</archiverConfig> | ||
<appendAssemblyId>false</appendAssemblyId> | ||
</configuration> | ||
<executions> | ||
<execution> | ||
<phase>package</phase> | ||
<goals> | ||
<goal>attached</goal> | ||
</goals> | ||
</execution> | ||
</executions> | ||
</plugin> | ||
<plugin> | ||
<groupId>org.apache.maven.plugins</groupId> | ||
<artifactId>maven-jar-plugin</artifactId> | ||
<version>2.4</version> | ||
<configuration> | ||
<archive> | ||
<manifest> | ||
<mainClass>org.apache.stratos.gce.extension.Main</mainClass> | ||
</manifest> | ||
</archive> | ||
</configuration> | ||
</plugin> | ||
</plugins> | ||
</build> | ||
</project> |
70 changes: 70 additions & 0 deletions
70
extensions/load-balancer/gce-extension/src/main/assembly/bin.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
<!-- | ||
~ Licensed to the Apache Software Foundation (ASF) under one | ||
~ or more contributor license agreements. See the NOTICE file | ||
~ distributed with this work for additional information | ||
~ regarding copyright ownership. The ASF licenses this file | ||
~ to you under the Apache License, Version 2.0 (the | ||
~ "License"); you may not use this file except in compliance | ||
~ with the License. You may obtain a copy of the License at | ||
~ | ||
~ http://www.apache.org/licenses/LICENSE-2.0 | ||
~ | ||
~ Unless required by applicable law or agreed to in writing, | ||
~ software distributed under the License is distributed on an | ||
~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
~ KIND, either express or implied. See the License for the | ||
~ specific language governing permissions and limitations | ||
~ under the License. | ||
--> | ||
|
||
<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd"> | ||
<id>bin</id> | ||
<formats> | ||
<format>zip</format> | ||
</formats> | ||
<fileSets> | ||
<fileSet> | ||
<directory>${project.basedir}/src/main/bin</directory> | ||
<outputDirectory>/bin</outputDirectory> | ||
<fileMode>0755</fileMode> | ||
<includes> | ||
<include>gce-extension.sh</include> | ||
</includes> | ||
</fileSet> | ||
<fileSet> | ||
<directory>${project.basedir}/src/main/conf</directory> | ||
<outputDirectory>/conf</outputDirectory> | ||
<fileMode>0600</fileMode> | ||
<includes> | ||
<include>jndi.properties</include> | ||
<include>log4j.properties</include> | ||
<include>thrift-client-config.xml</include> | ||
<include>gce-configuration.xml</include> | ||
</includes> | ||
</fileSet> | ||
<fileSet> | ||
<directory>${project.basedir}/src/main/security</directory> | ||
<outputDirectory>/security</outputDirectory> | ||
<fileMode>0600</fileMode> | ||
<includes> | ||
<include>client-truststore.jks</include> | ||
</includes> | ||
</fileSet> | ||
</fileSets> | ||
<dependencySets> | ||
<dependencySet> | ||
<outputDirectory>/lib</outputDirectory> | ||
<excludes> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this bin.xml copied from an existing load balancer extension? If so might need to refine the exclusion list. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi Imesh, |
||
<exclude>*:icu4j*</exclude> | ||
<exclude>*:jaxen*</exclude> | ||
<exclude>*:jboss-transaction-api*</exclude> | ||
<exclude>*:wrapper*</exclude> | ||
<exclude>*:xom*</exclude> | ||
</excludes> | ||
<useProjectArtifact>true</useProjectArtifact> | ||
<scope>runtime</scope> | ||
</dependencySet> | ||
</dependencySets> | ||
</assembly> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this constant used outside this class? If not may be we can make it private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Imesh,
currently that constant is private.