STORM-4057 - Validate user with the id cmd #3640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzo1
approved these changes
Jun 7, 2024
rzo1
changed the title
bipinprasad
reviewed
Jun 8, 2024
| LOG.debug("CMD: '{}' returned exit code of {}", String.join(" ", cmdArgs), exitCode); | ||
| cmdArgs.remove(user); | ||
| } | ||
| } | ||
| } | ||
| LOG.debug("CMD: {}", String.join(" ", cmdArgs)); | ||
| ProcessBuilder pb = new ProcessBuilder(cmdArgs); |
There was a problem hiding this comment.
I think so, yes. The first call is actually a test, if the user actually exist on the system (otherwise the parsing of the 2nd call would fail).
There was a problem hiding this comment.
The first call is a test. Whilst this code isn't optimal in terms of the number of OS calls being made, it keeps disruption to the current implementation to a minimum.
jnioche
approved these changes
Jun 8, 2024
bipinprasad
approved these changes
Jun 11, 2024
|
thanks @steveclark72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Validate the user associated with the id command for scenarios where the user running Storm in a container is not listed in the /etc/passwd file when a Worker process is to be terminated, e.g. with a custom securityContext in Kubernetes:
Without this change the Supervisor container itself dies rather than terminating the Worker process.
How was the change tested
I have tested the change locally running a Kubernetes cluster with this fix in place. The Worker process is successfully terminated and the Supervisor container does not die.