[SPARK-52751][PYTHON][CONNECT] Don't eagerly validate column name in dataframe['col_name']
#51400
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
test_fail_col
branch
from
dd2982b to
342ec47
Compare
zhengruifeng
force-pushed
the
test_fail_col
branch
2 times, most recently
from
d7c67da to
5405e02
Compare
zhengruifeng
changed the title
dataframe['col_name']
|
I'm wondering if there is a user facing error type/message change introduced? |
It is kind of behavior change, let me add a flag |
zhengruifeng
force-pushed
the
test_fail_col
branch
from
5405e02 to
ed431e2
Compare
zhengruifeng
force-pushed
the
test_fail_col
branch
from
ed431e2 to
13a7da9
Compare
zhengruifeng
force-pushed
the
test_fail_col
branch
from
13a7da9 to
b06f49f
Compare
zhengruifeng
force-pushed
the
test_fail_col
branch
from
b06f49f to
767ac66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't eagerly validate column name in
dataframe['col_name']Why are the changes needed?
to save ANALYZE RPC, fail the query on connect server side
Does this PR introduce any user-facing change?
yes,
df['bad_column']will fail on analysis or executionHow was this patch tested?
updated tests
Was this patch authored or co-authored using generative AI tooling?
no