[SPARK-37860][UI] Fix taskindex in the stage page task event timeline #35160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eline" This reverts commit 450b415.
|
cc @gengliangwang too |
|
Thank you, @stczwd ! |
sarutak
approved these changes
Jan 11, 2022
|
@stczwd Thank you for pointing out the issue! It LGTM and I'll merge this to |
sarutak
pushed a commit
that referenced
this pull request
Jan 11, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In #32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus #32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes #35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 3d2fde5) Signed-off-by: Kousuke Saruta <[email protected]>
sarutak
pushed a commit
that referenced
this pull request
Jan 11, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In #32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus #32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes #35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 3d2fde5) Signed-off-by: Kousuke Saruta <[email protected]>
sarutak
pushed a commit
that referenced
this pull request
Jan 11, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In #32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus #32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes #35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 3d2fde5) Signed-off-by: Kousuke Saruta <[email protected]>
|
Thanks @dongjoon-hyun @HyukjinKwon @sarutak |
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In apache#32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus apache#32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes apache#35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 3d2fde5) Signed-off-by: Kousuke Saruta <[email protected]>
dchvn
pushed a commit
to dchvn/spark
that referenced
this pull request
Jan 19, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In apache#32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus apache#32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes apache#35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Feb 22, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In apache#32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus apache#32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes apache#35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 3d2fde5) Signed-off-by: Kousuke Saruta <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Mar 4, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In apache#32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus apache#32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes apache#35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 3d2fde5) Signed-off-by: Kousuke Saruta <[email protected]>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? This reverts commit 450b415. ### Why are the changes needed? In apache#32888, shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use `index.attempt` or `taskId` to distinguish tasks within a stage, not `taskId.attempt`. Thus apache#32888 was a wrong fix issue, we should revert it. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? origin test suites Closes apache#35160 from stczwd/SPARK-37860. Authored-by: stczwd <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 3d2fde5) Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit db1023c) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit 450b415.
Why are the changes needed?
In #32888, @shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use
index.attemptortaskIdto distinguish tasks within a stage, nottaskId.attempt.Thus #32888 was a wrong fix issue, we should revert it.
Does this PR introduce any user-facing change?
no
How was this patch tested?
origin test suites