Skip to content

Fix endless loop for bad sql like "select * from table where id in ()" #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2018
Merged

Fix endless loop for bad sql like "select * from table where id in ()" #825

merged 2 commits into from
May 14, 2018

Conversation

maxiaoguang64
Copy link
Collaborator

@maxiaoguang64 maxiaoguang64 commented May 13, 2018

fix 827

@codecov-io
Copy link

codecov-io commented May 13, 2018

Codecov Report

Merging #825 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #825      +/-   ##
==========================================
+ Coverage   63.23%   63.25%   +0.02%     
==========================================
  Files         493      493              
  Lines        9713     9711       -2     
  Branches     1599     1599              
==========================================
+ Hits         6142     6143       +1     
+ Misses       3226     3220       -6     
- Partials      345      348       +3
Impacted Files Coverage Δ
.../core/parsing/parser/clause/WhereClauseParser.java 91.37% <100%> (-0.1%) ⬇️
.../internal/config/ConfigurationListenerManager.java 75% <0%> (+3.57%) ⬆️
...ternal/state/instance/InstanceListenerManager.java 42.3% <0%> (+3.84%) ⬆️
...al/state/datasource/DataSourceListenerManager.java 54.54% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d368e6a...b030905. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless loop for bad SQL like: SELECT * FROM table WHERE id IN ()
3 participants