[SEDONA-724] Fix RS_ZonalStats and RS_ZonalStatsAll edge case bug #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Mar 20, 2025
common/src/test/java/org/apache/sedona/common/raster/RasterBandAccessorsTest.java
Show resolved
Hide resolved
jiayuasu
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[SEDONA-724] my subject.What changes were proposed in this PR?
When the ROI barely intersects with the input raster's extent and the
allTouchedargument is false then this causes the pixel data to be empty. That breaks the zonalMode method which assumes there will be pixel data.Add better error handling and a shortcut for RS_ZonalStatsAll to skip unnecessary stats compute (saves ~6% time).
How was this patch tested?
Did this PR include necessary documentation updates?