fix peek messages failed with subscriptionName not exist #8182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sijie @codelipenghui Please take a look, thanks. |
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Oct 2, 2020
sijie
approved these changes
Oct 2, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
### Motivation When peek message with not exist subscriptionName, it will get the following exception: ```shell $bin/pulsar-admin topics peek-messages -s test persistent://public/default/test-v1-partition-2 22:11:29.237 [AsyncHttpClient-7-1] WARN org.apache.pulsar.client.admin.internal.TopicsImpl - Exception 'Subscription not found' occurred while trying to peek Messages. ``` ### Changes When the given subscriptionName not exist, create a new subscription with given subscriptionName and earliest initial position.
1 task
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
### Motivation When peek message with not exist subscriptionName, it will get the following exception: ```shell $bin/pulsar-admin topics peek-messages -s test persistent://public/default/test-v1-partition-2 22:11:29.237 [AsyncHttpClient-7-1] WARN org.apache.pulsar.client.admin.internal.TopicsImpl - Exception 'Subscription not found' occurred while trying to peek Messages. ``` ### Changes When the given subscriptionName not exist, create a new subscription with given subscriptionName and earliest initial position. (cherry picked from commit 8894b01)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
### Motivation When peek message with not exist subscriptionName, it will get the following exception: ```shell $bin/pulsar-admin topics peek-messages -s test persistent://public/default/test-v1-partition-2 22:11:29.237 [AsyncHttpClient-7-1] WARN org.apache.pulsar.client.admin.internal.TopicsImpl - Exception 'Subscription not found' occurred while trying to peek Messages. ``` ### Changes When the given subscriptionName not exist, create a new subscription with given subscriptionName and earliest initial position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When peek message with not exist subscriptionName, it will get the following exception:
Changes
When the given subscriptionName not exist, create a new subscription with given subscriptionName and earliest initial position.