[broker] Add replicated check to checkInactiveSubscriptions. #8066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed PersistentTopic. * Fixed PersistentTopicTest.
nkurihar
added
area/broker
type/enhancement
nkurihar
approved these changes
Sep 15, 2020
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 15, 2020
|
/pulsarbot run-failure-checks |
5 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Sep 21, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
### Motivation After replicated subscription is deleted by checkInactiveSubscriptions, it will be recreated. (That is repeated.) Replicated subscriptions are created with receiveSubscriptionUpdated. In this case, position becomes latest position. [https://github.com/apache/pulsar/blob/757824f88c06feb97968af6f5cdd7ccbea5ac666/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java#L182-L183](https://github.com/apache/pulsar/blob/757824f88c06feb97968af6f5cdd7ccbea5ac666/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java#L182-L183) I think replicated subscription should be excluded from automatic deletion. ### Modifications * Fixed PersistentTopic. * Fixed PersistentTopicTest.
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
### Motivation After replicated subscription is deleted by checkInactiveSubscriptions, it will be recreated. (That is repeated.) Replicated subscriptions are created with receiveSubscriptionUpdated. In this case, position becomes latest position. [https://github.com/apache/pulsar/blob/757824f88c06feb97968af6f5cdd7ccbea5ac666/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java#L182-L183](https://github.com/apache/pulsar/blob/757824f88c06feb97968af6f5cdd7ccbea5ac666/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java#L182-L183) I think replicated subscription should be excluded from automatic deletion. ### Modifications * Fixed PersistentTopic. * Fixed PersistentTopicTest. (cherry picked from commit 5d31568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After replicated subscription is deleted by checkInactiveSubscriptions, it will be recreated. (That is repeated.)
Replicated subscriptions are created with receiveSubscriptionUpdated.
In this case, position becomes latest position.
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java
Lines 182 to 183 in 757824f
I think replicated subscription should be excluded from automatic deletion.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation