Added REST and CLI tool to expose ManagedLedger metadata #292
Conversation
merlimat
added
the
type/feature
|
This PR is the last piece missing to complete #281 |
|
Ping @saandrews @rdhabalia |
|
yes, I will review it soon. |
|
|
||
| @Override | ||
| void run() throws PulsarAdminException { | ||
| String persistentTopic = validatePersistentTopic(params); |
There was a problem hiding this comment.
Is it needed here? Seems to be done inside getInternalInfo as well.
There was a problem hiding this comment.
params is a list of string arguments. validatePersistentTopic() is being used for all the commands to extract the topic name and ensure there are no other trailing arguments.
| @@ -110,4 +110,10 @@ | |||
| public void resetFailed(ManagedLedgerException exception, Object ctx); | |||
| } | |||
|
|
|||
| public interface ManagedLedgerInfoCallback { | |||
There was a problem hiding this comment.
may be as we have OpenLedgerCallback, should have GetLedgerInfoCallback with getLedgerInfoComplete()?
| DestinationName ds = validateTopic(destination); | ||
| final CompletableFuture<JsonObject> future = new CompletableFuture<>(); | ||
| asyncGetRequest(persistentTopics.path(ds.getNamespace()).path(ds.getEncodedLocalName()).path("internal-info"), | ||
| new InvocationCallback<String>() { |
There was a problem hiding this comment.
if server serialize ManagedLedgerInfo into json then if pass InvocationCallback<ManagedLedgerInfo> here : is JAXB not able to parse it?
There was a problem hiding this comment.
The reason for passing a JSONObject rather than a POJO is to avoid having the client depending on managed-ledger which is where the POJO is defined.
fix apache#289 upgrade pulsar dependency from `2.8.0-rc-202012200040` to `2.8.0-rc-202012242230`
Motivation
After enabling binary format for ManagedLedger metadata, we need a way to inspect
the metadata, parsing the binary protobuf format.
Modifications
Added REST, Java and CLI API to get the metadata dump. Any broker can answer the request, even if the ManagedLedger is not loaded at all.
New added command is:
Output:
{ "version": 8, "creationDate": "2017-03-13 21:00:56.594-0700", "modificationDate": "2017-03-13 23:14:20.308-0700", "ledgers": [ { "ledgerId": 8 } ], "cursors": { "sub": { "version": 8, "creationDate": "2017-03-13 21:00:56.844-0700", "modificationDate": "2017-03-13 23:15:21.236-0700", "cursorsLedgerId": -1, "markDelete": { "ledgerId": 8, "entryId": -1 } } } }