-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[improve][broker] Make maxBatchDeletedIndexToPersist configurable and document other related configs #24392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-revisit-ack-persistence-configuration
Jun 9, 2025
Merged
[improve][broker] Make maxBatchDeletedIndexToPersist configurable and document other related configs #24392
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-revisit-ack-persistence-configuration
Jun 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment other related configs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24392 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.65%
- Complexity 32624 32660 +36
============================================
Files 1877 1867 -10
Lines 139502 145281 +5779
Branches 15299 16612 +1313
============================================
+ Hits 102638 107843 +5205
+ Misses 28908 28892 -16
- Partials 7956 8546 +590
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Jun 6, 2025
This has been cherry-picked to maintenance branches, with a change where |
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 12, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65) (cherry picked from commit dfcc246)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 12, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65) (cherry picked from commit 17f04ef)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 12, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65) (cherry picked from commit dfcc246)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 13, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65) (cherry picked from commit dfcc246)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 13, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65) (cherry picked from commit 17f04ef)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 16, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65) (cherry picked from commit dfcc246)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 16, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65) (cherry picked from commit 17f04ef)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jun 18, 2025
… document other related configs (apache#24392) (cherry picked from commit d1bca65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
ready-to-test
release/3.0.13
release/3.3.8
release/4.0.6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
maxBatchDeletedIndexToPersist
has been hard coded to 10000 in Pulsar code base. It's better to make this configurable and also document the setting properly inbroker.conf
.managedLedgerPersistIndividualAckAsLongArray
setting was also missing frombroker.conf
and it's existing documentation inServiceConfiguration.java
didn't explain the impact to end users.Modifications
maxBatchDeletedIndexToPersist
by addingmanagedLedgerMaxBatchDeletedIndexToPersist
settingmanagedLedgerPersistIndividualAckAsLongArray
tobroker.conf
Additional Context
managedCursorInfoCompressionType
andmanagedLedgerInfoCompressionType
settings tobroker.conf
.managedCursorInfoCompressionType
is also related to persisting acknowledgement state.Documentation
doc
doc-required
doc-not-needed
doc-complete