Skip to content

[improve][broker] Make maxBatchDeletedIndexToPersist configurable and document other related configs #24392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 6, 2025

Motivation

maxBatchDeletedIndexToPersist has been hard coded to 10000 in Pulsar code base. It's better to make this configurable and also document the setting properly in broker.conf.
managedLedgerPersistIndividualAckAsLongArray setting was also missing from broker.conf and it's existing documentation in ServiceConfiguration.java didn't explain the impact to end users.

Modifications

  • make maxBatchDeletedIndexToPersist by adding managedLedgerMaxBatchDeletedIndexToPersist setting
  • add managedLedgerPersistIndividualAckAsLongArray to broker.conf
  • improve documentation for all of these settings

Additional Context

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.23%. Comparing base (bbc6224) to head (a831dbc).
Report is 1132 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24392      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.65%     
- Complexity    32624    32660      +36     
============================================
  Files          1877     1867      -10     
  Lines        139502   145281    +5779     
  Branches      15299    16612    +1313     
============================================
+ Hits         102638   107843    +5205     
+ Misses        28908    28892      -16     
- Partials       7956     8546     +590     
Flag Coverage Δ
inttests 26.65% <100.00%> (+2.07%) ⬆️
systests 23.29% <100.00%> (-1.03%) ⬇️
unittests 73.71% <100.00%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...apache/bookkeeper/mledger/ManagedLedgerConfig.java 96.55% <100.00%> (+0.25%) ⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java 98.16% <100.00%> (-1.23%) ⬇️
...rg/apache/pulsar/broker/service/BrokerService.java 83.83% <100.00%> (+3.05%) ⬆️

... and 1078 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari requested a review from merlimat June 6, 2025 16:39
@Denovo1998
Copy link
Contributor

LGTM!

When the contents of #24391 and #24392 are finalized and merged, I will update again the description of these configurations in PIP-423.

@lhotari lhotari merged commit d1bca65 into apache:master Jun 9, 2025
56 of 57 checks passed
lhotari added a commit that referenced this pull request Jun 9, 2025
… document other related configs (#24392)

(cherry picked from commit d1bca65)
lhotari added a commit that referenced this pull request Jun 9, 2025
… document other related configs (#24392)

(cherry picked from commit d1bca65)
@lhotari
Copy link
Member Author

lhotari commented Jun 9, 2025

This has been cherry-picked to maintenance branches, with a change where managedLedgerPersistIndividualAckAsLongArray defaults to false.

lhotari added a commit that referenced this pull request Jun 9, 2025
… document other related configs (#24392)

(cherry picked from commit d1bca65)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 12, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)
(cherry picked from commit dfcc246)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 12, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)

(cherry picked from commit 17f04ef)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 12, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)
(cherry picked from commit dfcc246)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 13, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)
(cherry picked from commit dfcc246)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 13, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)

(cherry picked from commit 17f04ef)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 16, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)
(cherry picked from commit dfcc246)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 16, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)

(cherry picked from commit 17f04ef)
nodece pushed a commit to nodece/pulsar that referenced this pull request Jun 18, 2025
… document other related configs (apache#24392)

(cherry picked from commit d1bca65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants