Skip to content

[fix][client] Fix producer publishing getting stuck after message with incompatible schema is discarded #24282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

poorbarcode
Copy link
Contributor

Fixes #24262

Main Issue: #24262

Motivation

The issue is a regression of #24178. The flow of the issue occurring is as follows

  • Publish msg 1, which has an incompatible schema
  • Publish msg 2, which has an incompatible schema
  • The first message's schema failed to register because it is incompatible
    • The message was discarded.
    • Issue: it did not trigger a schema registration of the following messages

Modifications

Fix the issue

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 4.1.0 milestone May 9, 2025
@poorbarcode poorbarcode self-assigned this May 9, 2025
@poorbarcode poorbarcode added type/bug The PR fixed a bug or issue reported a bug release/3.0.12 release/3.3.7 release/4.0.5 labels May 9, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 9, 2025
@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@lhotari lhotari changed the title [fix][client]Fix publish stuck once a messages was dicarded due to boken schema [fix][client] Fix producer publishing getting stuck after message with incompatible schema is discarded May 9, 2025
Copy link
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangyepianzhou liangyepianzhou merged commit df2c619 into apache:master May 12, 2025
55 checks passed
lhotari pushed a commit that referenced this pull request May 14, 2025
…h incompatible schema is discarded (#24282)

Fixes #24262

Main Issue: #24262

### Motivation

The issue is a regression of #24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

### Modifications

Fix the issue

(cherry picked from commit df2c619)
lhotari pushed a commit that referenced this pull request May 14, 2025
…h incompatible schema is discarded (#24282)

Fixes #24262

Main Issue: #24262

### Motivation

The issue is a regression of #24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

### Modifications

Fix the issue

(cherry picked from commit df2c619)
lhotari pushed a commit that referenced this pull request May 14, 2025
…h incompatible schema is discarded (#24282)

Fixes #24262

Main Issue: #24262

### Motivation

The issue is a regression of #24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

### Modifications

Fix the issue

(cherry picked from commit df2c619)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…h incompatible schema is discarded (apache#24282)

Fixes apache#24262

Main Issue: apache#24262

The issue is a regression of apache#24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

Fix the issue

(cherry picked from commit df2c619)
(cherry picked from commit 5496d92)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…h incompatible schema is discarded (apache#24282)

Fixes apache#24262

Main Issue: apache#24262

The issue is a regression of apache#24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

Fix the issue

(cherry picked from commit df2c619)
(cherry picked from commit 5496d92)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…h incompatible schema is discarded (apache#24282)

Fixes apache#24262

Main Issue: apache#24262

The issue is a regression of apache#24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

Fix the issue

(cherry picked from commit df2c619)
(cherry picked from commit 5496d92)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…h incompatible schema is discarded (apache#24282)

Fixes apache#24262

Main Issue: apache#24262

The issue is a regression of apache#24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

Fix the issue

(cherry picked from commit df2c619)
(cherry picked from commit a66d6b7)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2025
…h incompatible schema is discarded (apache#24282)

Fixes apache#24262

Main Issue: apache#24262

The issue is a regression of apache#24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

Fix the issue

(cherry picked from commit df2c619)
(cherry picked from commit 5496d92)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2025
…h incompatible schema is discarded (apache#24282)

Fixes apache#24262

Main Issue: apache#24262

The issue is a regression of apache#24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

Fix the issue

(cherry picked from commit df2c619)
(cherry picked from commit 5496d92)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
…h incompatible schema is discarded (apache#24282)

Fixes apache#24262

Main Issue: apache#24262

The issue is a regression of apache#24178. The flow of the issue occurring is as follows

- Publish msg 1, which has an incompatible schema
- Publish msg 2, which has an incompatible schema
- The first message's schema failed to register because it is incompatible
  - The message was discarded.
  - Issue: it did not trigger a schema registration of the following messages

Fix the issue

(cherry picked from commit df2c619)
(cherry picked from commit a66d6b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky-test: SchemaTest.testPendingQueueSizeIfIncompatible
5 participants