[fix][broker] Fix HashedWheelTimer leak in PulsarService by stopping it in shutdown #24275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
approved these changes
May 8, 2025
nodece
approved these changes
May 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24275 +/- ##
============================================
+ Coverage 73.57% 74.15% +0.58%
+ Complexity 32624 32191 -433
============================================
Files 1877 1866 -11
Lines 139502 145050 +5548
Branches 15299 16580 +1281
============================================
+ Hits 102638 107562 +4924
- Misses 28908 28955 +47
- Partials 7956 8533 +577
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit 5e734b6)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit d8eb65d)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit 5e734b6)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit d8eb65d)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit d8eb65d)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit d8eb65d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit d8eb65d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672) (cherry picked from commit 5e734b6)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
…it in shutdown (apache#24275) (cherry picked from commit 1280672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Netty leak detector detects also HashedWheelTimer leaks besides ByteBuf leaks. It reports in some tests that HashedWheelTimer has leaked. This leak doesn't seem to happen in all cases and doesn't really impact production usage.
Fixing this is needed for executing the plan explained in Enhancing Pulsar CI with Netty leak detection and reporting.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete