Skip to content

[cleanup] remove unused config messagePublishBufferCheckIntervalInMillis #24252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented May 6, 2025

Motivation

This config was introduced by #6178, but it never used.

Modifications

Remove unused config messagePublishBufferCheckIntervalInMillis

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@dao-jun dao-jun added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/broker ready-to-test labels May 6, 2025
@dao-jun dao-jun self-assigned this May 6, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.20%. Comparing base (bbc6224) to head (2cff3c1).
Report is 1068 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24252      +/-   ##
============================================
+ Coverage     73.57%   74.20%   +0.62%     
+ Complexity    32624    32565      -59     
============================================
  Files          1877     1866      -11     
  Lines        139502   144971    +5469     
  Branches      15299    16561    +1262     
============================================
+ Hits         102638   107569    +4931     
+ Misses        28908    28880      -28     
- Partials       7956     8522     +566     
Flag Coverage Δ
inttests 26.72% <ø> (+2.13%) ⬆️
systests 23.30% <ø> (-1.03%) ⬇️
unittests 73.68% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 98.16% <ø> (-1.24%) ⬇️

... and 1080 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari added this to the 4.1.0 milestone May 6, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 825b862 into apache:master May 6, 2025
55 of 56 checks passed
@dao-jun dao-jun deleted the dev/remove_unused_messagePublishBufferCheckIntervalInMillis branch May 6, 2025 09:44
lhotari pushed a commit that referenced this pull request May 9, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…lis (apache#24252)

(cherry picked from commit 825b862)
(cherry picked from commit ee39938)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…lis (apache#24252)

(cherry picked from commit 825b862)
(cherry picked from commit ee39938)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
…lis (apache#24252)

(cherry picked from commit 825b862)
(cherry picked from commit ee39938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/4.0.5 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants