-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[cleanup] remove unused config messagePublishBufferCheckIntervalInMillis #24252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 1 commit into
apache:master
from
dao-jun:dev/remove_unused_messagePublishBufferCheckIntervalInMillis
May 6, 2025
Merged
[cleanup] remove unused config messagePublishBufferCheckIntervalInMillis #24252
lhotari
merged 1 commit into
apache:master
from
dao-jun:dev/remove_unused_messagePublishBufferCheckIntervalInMillis
May 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetumbled
approved these changes
May 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24252 +/- ##
============================================
+ Coverage 73.57% 74.20% +0.62%
+ Complexity 32624 32565 -59
============================================
Files 1877 1866 -11
Lines 139502 144971 +5469
Branches 15299 16561 +1262
============================================
+ Hits 102638 107569 +4931
+ Misses 28908 28880 -28
- Partials 7956 8522 +566
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
lhotari
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…lis (apache#24252) (cherry picked from commit 825b862) (cherry picked from commit ee39938)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…lis (apache#24252) (cherry picked from commit 825b862) (cherry picked from commit ee39938)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2025
…lis (apache#24252) (cherry picked from commit 825b862) (cherry picked from commit ee39938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/4.0.5
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This config was introduced by #6178, but it never used.
Modifications
Remove unused config messagePublishBufferCheckIntervalInMillis
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete