Skip to content

[improve][build] Upgrade SpotBugs to 4.9.x #24243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 3, 2025

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 2, 2025

Motivation & Modifications

Upgrade SpotBugs to 4.9.3 to support Java 24 byte code. Since SpotBug introduces new checks since 4.7.x, it's necessary to first disable the new checks with the "omitVisitors" configuration.
It would be useful to address SpotBugs errors later and an issue can be filed to track this after this PR has been merged.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone May 2, 2025
@lhotari lhotari self-assigned this May 2, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.22%. Comparing base (bbc6224) to head (2e78bfa).
Report is 1064 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24243      +/-   ##
============================================
+ Coverage     73.57%   74.22%   +0.64%     
+ Complexity    32624    32212     -412     
============================================
  Files          1877     1866      -11     
  Lines        139502   144976    +5474     
  Branches      15299    16561    +1262     
============================================
+ Hits         102638   107606    +4968     
+ Misses        28908    28848      -60     
- Partials       7956     8522     +566     
Flag Coverage Δ
inttests 26.64% <ø> (+2.06%) ⬆️
systests 23.31% <ø> (-1.02%) ⬇️
unittests 73.70% <ø> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...che/pulsar/common/policies/data/TopicPolicies.java 20.68% <ø> (-38.69%) ⬇️
...licies/data/stats/NonPersistentTopicStatsImpl.java 83.78% <ø> (ø)

... and 1076 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodece nodece merged commit 53224ec into apache:master May 3, 2025
51 of 52 checks passed
lhotari added a commit that referenced this pull request May 5, 2025
lhotari added a commit that referenced this pull request May 5, 2025
lhotari added a commit that referenced this pull request May 5, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 7, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit 63fe42a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 7, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit 63fe42a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 8, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit 63fe42a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 8, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit 63fe42a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 8, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit 63fe42a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 8, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit d7abf32)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 8, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit d7abf32)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 12, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit 63fe42a)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
(cherry picked from commit 53224ec)
(cherry picked from commit d7abf32)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants