-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[improve][build] Upgrade SpotBugs to 4.9.x #24243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
approved these changes
May 2, 2025
nodece
approved these changes
May 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24243 +/- ##
============================================
+ Coverage 73.57% 74.22% +0.64%
+ Complexity 32624 32212 -412
============================================
Files 1877 1866 -11
Lines 139502 144976 +5474
Branches 15299 16561 +1262
============================================
+ Hits 102638 107606 +4968
+ Misses 28908 28848 -60
- Partials 7956 8522 +566
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
9 tasks
lhotari
added a commit
that referenced
this pull request
May 5, 2025
(cherry picked from commit 53224ec)
lhotari
added a commit
that referenced
this pull request
May 5, 2025
(cherry picked from commit 53224ec)
lhotari
added a commit
that referenced
this pull request
May 5, 2025
(cherry picked from commit 53224ec)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
(cherry picked from commit 53224ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.12
release/3.3.7
release/4.0.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Upgrade SpotBugs to 4.9.3 to support Java 24 byte code. Since SpotBug introduces new checks since 4.7.x, it's necessary to first disable the new checks with the "omitVisitors" configuration.
It would be useful to address SpotBugs errors later and an issue can be filed to track this after this PR has been merged.
Documentation
doc
doc-required
doc-not-needed
doc-complete