[improve][misc] Migrate from multiple nullness annotation libraries to JSpecify annotations #24239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g.jspecify.annotations.NonNull
lhotari
requested review from
merlimat,
Technoboy-,
eolivelli,
cbornet,
nodece,
BewareMyPower,
nicoloboschi,
onobc and
mattisonchao
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
May 2, 2025
…o JSpecify annotations (apache#24239)
heesung-sn
approved these changes
May 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24239 +/- ##
============================================
+ Coverage 73.57% 74.17% +0.59%
+ Complexity 32624 32557 -67
============================================
Files 1877 1866 -11
Lines 139502 144976 +5474
Branches 15299 16561 +1262
============================================
+ Hits 102638 107530 +4892
- Misses 28908 28915 +7
- Partials 7956 8531 +575
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
approved these changes
May 3, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 8, 2025
…o JSpecify annotations (apache#24239) (cherry picked from commit 9a11245) (cherry picked from commit 62c505d)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 8, 2025
…o JSpecify annotations (apache#24239) (cherry picked from commit 9a11245) (cherry picked from commit 62c505d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…o JSpecify annotations (apache#24239) (cherry picked from commit 9a11245) (cherry picked from commit 62c505d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are currently using multiple nullness annotations libraries.
Many JDK, tool and library vendors have standardized on JSpecify nullness annotations so that each vendor doesn't introduce its own classes for this purpose. We should migrate too.
In addition, one additional motivation is that recent Google Guava versions no longer contains a transitive dependency on checker-qual library.
Modifications
migrate these to
org.jspecify.annotations.NonNullorg.checkerframework.checker.nullness.qual.NonNulljavax.annotation.Nonnullorg.jetbrains.annotations.NotNullmigrate these to
org.jspecify.annotations.Nullableorg.checkerframework.checker.nullness.qual.Nullablejavax.annotation.Nullableorg.jetbrains.annotations.NullableIn addition there was code that was using javax.validation annotations for nullness information. That's invalid since those annotations are used for user input validation and not static code analysis.
Add checkstyle rules:
Documentation
docdoc-requireddoc-not-neededdoc-complete