-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix][test] Fix UnfinishedStubbing issue in AuthZTests #24165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodece
merged 2 commits into
apache:master
from
lhotari:lh-fix-UnfinishedStubbing-issue-in-AuthZTests
Apr 10, 2025
Merged
[fix][test] Fix UnfinishedStubbing issue in AuthZTests #24165
nodece
merged 2 commits into
apache:master
from
lhotari:lh-fix-UnfinishedStubbing-issue-in-AuthZTests
Apr 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ERROR] Failures: [ERROR] NamespaceAuthZTest.testMaxConsumersPerTopic:1537->setAuthorizationPolicyOperationChecker:183 » UnfinishedStubbing Unfinished stubbing detected here: -> at org.apache.pulsar.broker.admin.NamespaceAuthZTest.setAuthorizationPolicyOperationChecker(NamespaceAuthZTest.java:173) E.g. thenReturn() may be missing. Examples of correct stubbing: when(mock.isOk()).thenReturn(true); when(mock.isOk()).thenThrow(exception); doThrow(exception).when(mock).someVoidMethod(); Hints: 1. missing thenReturn() 2. you are trying to stub a final method, which is not supported 3. you are stubbing the behaviour of another mock inside before 'thenReturn' instruction is completed
heesung-sn
approved these changes
Apr 9, 2025
liangyepianzhou
approved these changes
Apr 10, 2025
4 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Apr 14, 2025
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Apr 15, 2025
lhotari
added a commit
that referenced
this pull request
Apr 17, 2025
(cherry picked from commit e8be56d)
depends on #22546 which isn't included in branch-3.0, dropping cherry-picking to branch-3.0 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.3.7
release/4.0.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Mockito is not thread safe and modifying mocks in multi-threaded code will result in failures such as this one:
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete