[fix][broker] fix ExtensibleLoadManager to override the ownerships concurrently without blocking load manager thread #24156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncurrently without blocking load manager thread
|
@heesung-sn Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
Demogorgon314
approved these changes
Apr 8, 2025
lhotari
reviewed
Apr 8, 2025
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Show resolved
Hide resolved
2 tasks
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Apr 15, 2025
…ncurrently without blocking load manager thread (apache#24156)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2025
…ncurrently without blocking load manager thread (apache#24156) (cherry picked from commit 066a20c) (cherry picked from commit 970df5f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…ncurrently without blocking load manager thread (apache#24156) (cherry picked from commit 066a20c) (cherry picked from commit 970df5f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…ncurrently without blocking load manager thread (apache#24156) (cherry picked from commit 066a20c) (cherry picked from commit 970df5f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…ncurrently without blocking load manager thread (apache#24156) (cherry picked from commit 066a20c) (cherry picked from commit 970df5f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…ncurrently without blocking load manager thread (apache#24156) (cherry picked from commit 066a20c) (cherry picked from commit 970df5f)
15 tasks
|
This fix has this bug. please pull this PR as well. #24196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, ExtensibleLoadManager overrides orphan ownerships one by one while holding the monitor lock. This can delay the synchronized serviceUnitStateChannel.started() call(required for SystemTopicPoliciesService.getTopicPoliciesAsync and others) when the metadata service is slow(is overloaded).
Modifications
loadBalancerServiceUnitStateMaxConcurrentOverrides).TopBundlesLoadData is emptylog under debug flagVerifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: