-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix][test] Fix flaky NonPersistentTopicTest.testMsgDropStat #24134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t.testMsgDropStat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24134 +/- ##
============================================
+ Coverage 73.57% 74.26% +0.68%
+ Complexity 32624 32497 -127
============================================
Files 1877 1864 -13
Lines 139502 144453 +4951
Branches 15299 16479 +1180
============================================
+ Hits 102638 107275 +4637
+ Misses 28908 28724 -184
- Partials 7956 8454 +498
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Thanks for the contribution @pdolif, good work! |
(cherry picked from commit acec48c)
(cherry picked from commit acec48c)
Fixes #20386
Motivation
It seems that messages are dropped very fast, so the drop stats are already 0 again once we reach the assertion.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: pdolif#9