-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[improve][io] Remove sleep when sourceTask.poll of kafka return null #24124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
approved these changes
Mar 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24124 +/- ##
============================================
+ Coverage 73.57% 74.27% +0.70%
+ Complexity 32624 32114 -510
============================================
Files 1877 1864 -13
Lines 139502 144440 +4938
Branches 15299 16468 +1169
============================================
+ Hits 102638 107285 +4647
+ Misses 28908 28709 -199
- Partials 7956 8446 +490
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 27, 2025
…pache#24124) (cherry picked from commit d0c996e)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 27, 2025
…pache#24124) (cherry picked from commit d0c996e) (cherry picked from commit c4ecefe)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…pache#24124) (cherry picked from commit d0c996e) (cherry picked from commit c4ecefe)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…pache#24124) (cherry picked from commit d0c996e) (cherry picked from commit 0782b7d)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2025
…pache#24124) (cherry picked from commit d0c996e) (cherry picked from commit 0782b7d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 31, 2025
…pache#24124) (cherry picked from commit d0c996e) (cherry picked from commit 0782b7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.11
release/3.3.6
release/4.0.4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We observe our debezium source connector latency min is 1s when traffic is small.
According to the Kafka Source API definition, when there is no data, the implementation should block for a period of time. We don't need to actively sleep here to avoid CPU spinning.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: