Add lookup throttling in cpp-client #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
added
the
type/enhancement
merlimat
approved these changes
Feb 18, 2017
| @@ -267,6 +267,9 @@ class ClientConnection : public boost::enable_shared_from_this<ClientConnection> | |||
| bool havePendingPingRequest_; | |||
| DeadlineTimerPtr keepAliveTimer_; | |||
|
|
|||
| unsigned long maxPendingLookupRequest_; | |||
There was a problem hiding this comment.
Use type with the size info, e.g.: either uint32_t or uint64_t. In this case 32 bits should be enough
rdhabalia
force-pushed
the
cpp_throttling
branch
from
41da470 to
5870f36
Compare
merlimat
approved these changes
Feb 18, 2017
|
👍 |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* adding checks for parallelism * fixing unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes, It is useful to throttle at client in order to avoid large number of concurrent lookup-requests going to broker while creating producers/consumers.
Modifications
Add client side lookup throttling while creating producer and consumer.
Result
Client can have capability to restrict number of concurrent lookup request to broker in order to throttle while creating producer/consumer.