Discovery service should use HTTP temporary redirect (307) #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@merlimat this fix has caught a bug in test-case as well: Can we change assert-string as : |
|
Yes, the test was sending a POST and comparing with the response for the GET operation. I'll fix that |
merlimat
force-pushed
the
discovery-service-redirection
branch
2 times, most recently
from
5986c63 to
647490c
Compare
|
👍 |
merlimat
force-pushed
the
discovery-service-redirection
branch
from
647490c to
ced33b5
Compare
merlimat
force-pushed
the
discovery-service-redirection
branch
from
ced33b5 to
c928664
Compare
merlimat
changed the title
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
HTTP redirections in discovery service component need to be done with 307 code instead of 302, as the broker is already doing.
When redirecting with 302, the HTTP method gets converted into a GET in the subsequent requests, when originally it might have been a POST or a PUT request.