-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update docs for Go client #10490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update docs for Go client #10490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolongran <[email protected]>
Anonymitaet
reviewed
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution. I’ve left some comments, PTAL, thanks.
Signed-off-by: xiaolongran <[email protected]>
@Anonymitaet Thanks yu, PTAL again, thanks. |
Anonymitaet
approved these changes
May 6, 2021
merlimat
approved these changes
May 6, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
* Update docs for Go client Signed-off-by: xiaolongran <[email protected]> * Fix comments Signed-off-by: xiaolongran <[email protected]> Co-authored-by: xiaolongran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolongran [email protected]
Motivation
With the iteration of the Go client version, we have introduced many new interfaces and parameters, but the relevant documents have not been updated, resulting in inconsistencies between the documents and the code. This pr will focus on solving this problem and sort out all the parameters and interface lists related to
client
,producer
,consumer
andreader
in the current Go client. Ensure that the documentation and code are consistent.Modifications
Schema
docs and code example for producer and consumerVerifying this change