Skip to content

fix: use sha instead of tag for golangci/golangci-lint-action #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nodece
Copy link
Member

@nodece nodece commented Apr 2, 2025

Motivation

Because of the ASF policy, the CI cannot use golangci/golangci-lint-action@v6, it has been fixed by apache/infrastructure-actions#142.

golangci/golangci-lint-action@v6 is not allowed to be used in apache/pulsar-client-go. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following: 1Password/load-secrets-action@*, AdoptOpenJDK/install-jdk@*, BobAnkh/auto-generate-changelog@*, DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8, DavidAnson/markdownlint-cli2-action@v16, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@881db5376404c5c8d621010bcbec0310b58d5e29, JamesIves/[email protected], JustinBeckwith/linkinator-action@3d5ba091319fa7b0ac14703761eebb7d100e6f6d, JustinBeckwith/[email protected], Kesin11/actions-timeline@427ee2cf860166e404d0d69b4f2b24012bb7af4f, Madrapps/jacoco-report@fd4800e8a81e21bdf373438e5918b975df041d15, PyO3/maturin-action@*, TobKed/label-when-approved-action@*, VirtusLab/[email protected] less

Modifications

  • Use sha instead of tag for golangci/golangci-lint-action.

@nodece nodece closed this Apr 2, 2025
@nodece nodece reopened this Apr 2, 2025
@nodece nodece requested a review from dao-jun April 3, 2025 06:20
@nodece nodece self-assigned this Apr 3, 2025
@nodece nodece added this to the v0.15.0 milestone Apr 3, 2025
@crossoverJie crossoverJie merged commit 712e14c into apache:master Apr 3, 2025
8 checks passed
@nodece nodece deleted the fix-golangci/golangci-lint-action branch April 3, 2025 08:27
RobertIndie pushed a commit that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants