Skip to content

Update the nodejs action kind #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

style95
Copy link
Member

@style95 style95 commented Aug 14, 2023

Description

This is just a missing part from the recent update.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #5434 (a5cf272) into master (951ce58) will increase coverage by 18.26%.
The diff coverage is n/a.

❗ Current head a5cf272 differs from pull request most recent head 84ec340. Consider uploading reports for the commit 84ec340 to get more accurate results

@@             Coverage Diff             @@
##           master    #5434       +/-   ##
===========================================
+ Coverage   58.52%   76.78%   +18.26%     
===========================================
  Files         241      241               
  Lines       14632    14632               
  Branches      616      616               
===========================================
+ Hits         8563    11235     +2672     
+ Misses       6069     3397     -2672     

see 137 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@style95
Copy link
Member Author

style95 commented Aug 14, 2023

I got into the runner and found this error.
It failed to pause a container with runc.

[2023-08-14T05:08:55.047Z] [ERROR] [#tid_sid_invokerNanny] [RuncClient] info: command was unsuccessful, code: 1 (unsuccessful), stdout: , stderr: no such directory for freezer.state [marker:invoker_runc.pause_error:530099:217]

This generally happens when the runc volume is not properly mounted into the invoker container.

And I realized the CI environment is using the default docker engine provided by the runner.

$ docker version
Client:
 Version:           23.0.6+azure-2
 API version:       1.42
 Go version:        go1.19.10
 Git commit:        ef23cbc4315ae76c744e02d687c09548ede461bd
 Built:             Thu May  4 10:51:27 UTC 2023
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          23.0.6+azure-2
  API version:      1.42 (minimum version 1.12)
  Go version:       go1.19.10
  Git commit:       9dbdbd4b6d7681bd18c897a6ba0376073c2a72ff
  Built:            Fri May  5 20:50:10 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.22+azure-1
  GitCommit:        8165feabfdfe38c65b599c4993d227328c231fca
 runc:
  Version:          1.1.8
  GitCommit:        82f18fe0e44a59034f3e1f45e475fa5636e539aa
 docker-init:
  Version:          0.19.0
  GitCommit:

We are still sticking to the docker-18.06.3 for some reason.
https://github.com/apache/openwhisk/blob/master/tools/ubuntu-setup/docker.sh#L38

I think we need to downgrade the docker binary in runners.

Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this!

@style95 style95 force-pushed the update-nodjes-kind branch from f22ed69 to 84ec340 Compare August 16, 2023 00:59
@style95 style95 merged commit 20f7d98 into apache:master Aug 17, 2023
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants