Skip to content

Finish setup on error #5419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2023
Merged

Finish setup on error #5419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1531ff2
Fast-fail on errors
style95 May 30, 2023
1951321
Fix an indentation error
style95 May 30, 2023
740e265
Fail the setup script on an error
style95 May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/0-on-demand.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ env:
jobs:
openwhisk:
runs-on: ubuntu-22.04
continue-on-error: false
strategy:
fail-fast: true
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/1-unit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,14 @@ env:

# github
GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}

jobs:
openwhisk:
runs-on: ubuntu-22.04
continue-on-error: false
strategy:
fail-fast: true
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/2-system.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ env:

# github
GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}

jobs:
openwhisk:
runs-on: ubuntu-22.04
continue-on-error: false
strategy:
fail-fast: true
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/3-multi-runtime.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ env:

# github
GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}

jobs:
openwhisk:
runs-on: ubuntu-22.04
continue-on-error: false
strategy:
fail-fast: true
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/4-standalone.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ env:

# github
GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}

jobs:
openwhisk:
runs-on: ubuntu-22.04
continue-on-error: false
strategy:
fail-fast: true
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/5-scheduler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ env:

# github
GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}

jobs:
openwhisk:
runs-on: ubuntu-22.04
continue-on-error: false
strategy:
fail-fast: true
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
17 changes: 10 additions & 7 deletions .github/workflows/6-performance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ env:

# github
GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}
GH_BRANCH: ${{ github.head_ref || github.ref_name }}

jobs:
openwhisk:
runs-on: ubuntu-22.04
continue-on-error: false
strategy:
fail-fast: true
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down Expand Up @@ -79,9 +82,9 @@ jobs:
- run: OPENWHISK_HOST="172.17.0.1" USERS="1" REQUESTS_PER_SEC="1" ./gradlew gatlingRun-org.apache.openwhisk.ColdBlockingInvokeSimulation
continue-on-error: true
- name: Slack Notification
run: >
./tools/github/writeOnSlack.sh
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
$'\nbranch:' $GH_BRANCH
$'\nmessage:' "$(git log -1 --oneline | cat)"
$'\nCheck GitHub logs for results'
run: >
./tools/github/writeOnSlack.sh
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
$'\nbranch:' $GH_BRANCH
$'\nmessage:' "$(git log -1 --oneline | cat)"
$'\nCheck GitHub logs for results'
2 changes: 2 additions & 0 deletions tools/github/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#then echo skipping setup ; exit 0
#fi

set -e
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required to finish on an error.
Now it works as expected.
image

I will revert the temporary commit.


# retries a command for five times and exits with the non-zero exit if even after
# the retries the command did not succeed.
function retry() {
Expand Down