Skip to content

update scheduler not processing metric to counter #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bdoyle0182
Copy link
Contributor

Description

This metric unfortunately does not work as a gauge. A gauge will report until there is a change in the value. I previously made a change so that the value would change back to 0 when a new activation is processed. However this does not account for 1. when the queue is stopped before setting the value back to 0 and 2. a queue is moved to a new host before the value is set back to 0 so the value for the action is still emitting 1 until a restart incorrectly reporting.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #5405 (ccfac09) into master (d84e4ee) will decrease coverage by 1.05%.
The diff coverage is 0.00%.

❗ Current head ccfac09 differs from pull request most recent head 43ba7da. Consider uploading reports for the commit 43ba7da to get more accurate results

@@            Coverage Diff             @@
##           master    #5405      +/-   ##
==========================================
- Coverage   76.69%   75.65%   -1.05%     
==========================================
  Files         240      240              
  Lines       14596    14592       -4     
  Branches      671      666       -5     
==========================================
- Hits        11194    11039     -155     
- Misses       3402     3553     +151     
Impacted Files Coverage Δ
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 81.03% <0.00%> (+0.59%) ⬆️

... and 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdoyle0182 bdoyle0182 merged commit a22e706 into apache:master May 3, 2023
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
Co-authored-by: Brendan Doyle <[email protected]>
(cherry picked from commit a22e706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants