Skip to content

fix action not processing metric #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

bdoyle0182
Copy link
Contributor

Description

Since the metric is a gauge, it will continue reporting the value once an action starts not processing and will never recover from the metric's perspective even if the action has actually recovered. Setting the gauge back to 0 should handle recovery without requiring a restart.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@bdoyle0182 bdoyle0182 requested a review from style95 April 12, 2023 22:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #5395 (70162e3) into master (cb3b64f) will decrease coverage by 11.32%.
The diff coverage is 0.00%.

❗ Current head 70162e3 differs from pull request most recent head e9f29cd. Consider uploading reports for the commit e9f29cd to get more accurate results

@@             Coverage Diff             @@
##           master    #5395       +/-   ##
===========================================
- Coverage   76.87%   65.55%   -11.32%     
===========================================
  Files         240      240               
  Lines       14597    14600        +3     
  Branches      620      634       +14     
===========================================
- Hits        11221     9571     -1650     
- Misses       3376     5029     +1653     
Impacted Files Coverage Δ
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 0.00% <0.00%> (-82.36%) ⬇️

... and 56 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdoyle0182 bdoyle0182 merged commit 4e2dea1 into apache:master Apr 13, 2023
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
Co-authored-by: Brendan Doyle <[email protected]>
(cherry picked from commit 4e2dea1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants