use compatibility serializer for future message forma… #5389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdoyle0182
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5389 +/- ##
==========================================
- Coverage 76.91% 76.70% -0.22%
==========================================
Files 240 240
Lines 14588 14589 +1
Branches 629 630 +1
==========================================
- Hits 11221 11191 -30
- Misses 3367 3398 +31
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
style95
approved these changes
Mar 30, 2023
|
Do we need to send a notice about the breaking change via the dev mailing list? |
mtt-merz
pushed a commit
to mtt-merz/openwhisk
that referenced
this pull request
Oct 22, 2023
* update kryo and use compatibility serializer for future message format changes * revert kryo major upgrade --------- Co-authored-by: Brendan Doyle <[email protected]> (cherry picked from commit be8ac20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support future changes to the akka serialized messages that use kryo, we need to use kryo compatibility serializer i.e. to support the max instances pr.
This is a breaking change if trying to rolling upgrade an existing cluster creating new action queues between the scheduler and controller.
If you are not using the new scheduler architecture, this change is completely non-impacting. If you are using the new scheduler architecture, you can either do a blue / green deployment with a new cluster to upgrade or if you must do a rolling upgrade of an existing cluster; you can upgrade the controllers first such that only things that will return 503 during the deployment window are new actions that have not been running, live running queues in the scheduler would continue to be able to take activations.
Since this is a one time breaking serialization change to the scheduler, I've also taken the opportunity to perform the major version akka-kryo upgrade to handle cve's for kryo 4. edit: I've removed this part of the pr as there seems to be other issues with upgrading akka-kryo
Related issue and scope
My changes affect the following components
Types of changes
Checklist: