Skip to content

attempt to fix downstream runtime builds #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

attempt to fix downstream runtime builds #5384

merged 2 commits into from
Feb 24, 2023

Conversation

bdoyle0182
Copy link
Contributor

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@bdoyle0182 bdoyle0182 mentioned this pull request Feb 24, 2023
Merged
22 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #5384 (ce08108) into master (65a0132) will increase coverage by 0.21%.
The diff coverage is n/a.

❗ Current head ce08108 differs from pull request most recent head a15866f. Consider uploading reports for the commit a15866f to get more accurate results

@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
+ Coverage   76.45%   76.66%   +0.21%     
==========================================
  Files         240      240              
  Lines       14569    14569              
  Branches      647      647              
==========================================
+ Hits        11139    11170      +31     
+ Misses       3430     3399      -31
Impacted Files Coverage Δ
.../openwhisk/core/containerpool/ContainerProxy.scala 95.43% <0.00%> (+0.22%) ⬆️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 82.10% <0.00%> (+0.56%) ⬆️
...g/apache/openwhisk/common/ResizableSemaphore.scala 100.00% <0.00%> (+3.84%) ⬆️
...la/org/apache/openwhisk/core/etcd/EtcdClient.scala 60.00% <0.00%> (+4.61%) ⬆️
...pache/openwhisk/core/invoker/InvokerReactive.scala 71.53% <0.00%> (+17.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dgrove-oss dgrove-oss merged commit 6dd737d into apache:master Feb 24, 2023
@dgrove-oss
Copy link
Member

I'll rerun one of the downstream runtime jobs manually and see what happens...

@dgrove-oss
Copy link
Member

dgrove-oss commented Feb 24, 2023 •
edited
Loading

I think it made progress, but we're not out of the woods yet. Here's the snippet from the re-run of runttime-go (https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068)

> Task :tests:test FAILED
[30](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:31)
FAILURE: Build failed with an exception.
[31](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:32)

[32](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:33)
* What went wrong:
[33](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:34)
Execution failed for task ':tests:test'.
[34](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:35)
> Could not resolve all files for configuration ':tests:testRuntimeClasspath'.
[35](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:36)
   > Could not find com.atlassian.oai:swagger-request-validator-core:.
[36](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:37)
     Required by:
[37](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:38)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
[38](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:39)
   > Could not find io.github.embeddedkafka:embedded-kafka_2.12:.
[39](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:40)
     Required by:
[40](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:41)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT

@bdoyle0182
Copy link
Contributor Author

bdoyle0182 commented Feb 24, 2023 •
edited
Loading

I think it made progress, but we're not out of the woods yet. Here's the snippet from the re-run of runttime-go (https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068)

> Task :tests:test FAILED
[30](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:31)
FAILURE: Build failed with an exception.
[31](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:32)

[32](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:33)
* What went wrong:
[33](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:34)
Execution failed for task ':tests:test'.
[34](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:35)
> Could not resolve all files for configuration ':tests:testRuntimeClasspath'.
[35](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:36)
   > Could not find com.atlassian.oai:swagger-request-validator-core:.
[36](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:37)
     Required by:
[37](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:38)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
[38](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:39)
   > Could not find io.github.embeddedkafka:embedded-kafka_2.12:.
[39](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:40)
     Required by:
[40](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:41)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT

will get the rest of the dependencies from that pr updated and then seems like hopefully it should be good

edit: #5385

@bdoyle0182 bdoyle0182 deleted the fix-runtime-builds branch February 24, 2023 17:42
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
@bdoyle0182 @mtt-merz
attempt to fix downstream runtime builds (apache#5384)
0e2f984 
* attempt to fix downstream runtime builds

* fix scoverage resolution

---------

Co-authored-by: Brendan Doyle <[email protected]>
(cherry picked from commit 6dd737d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdoyle0182 @codecov-commenter @dgrove-oss