Skip to content

fix flaky ActivationClientProxy unit test #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

bdoyle0182
Copy link
Contributor

Description

I don't believe the inAnyOrder actually works as expected. This should fix the problematic test.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

Codecov Report

Merging #5382 (e725a00) into master (3ea756f) will increase coverage by 38.52%.
The diff coverage is n/a.

❗ Current head e725a00 differs from pull request most recent head 4f84445. Consider uploading reports for the commit 4f84445 to get more accurate results

@@             Coverage Diff             @@
##           master    #5382       +/-   ##
===========================================
+ Coverage   38.23%   76.75%   +38.52%     
===========================================
  Files         240      240               
  Lines       14569    14569               
  Branches      647      647               
===========================================
+ Hits         5570    11183     +5613     
+ Misses       8999     3386     -5613     
Impacted Files Coverage Δ
.../apache/openwhisk/core/controller/Controller.scala 83.96% <0.00%> (+0.76%) ⬆️
.../org/apache/openwhisk/core/entity/EntityPath.scala 100.00% <0.00%> (+1.88%) ⬆️
...apache/openwhisk/core/entitlement/Collection.scala 88.37% <0.00%> (+2.32%) ⬆️
...la/org/apache/openwhisk/core/invoker/Invoker.scala 72.15% <0.00%> (+2.53%) ⬆️
.../org/apache/openwhisk/http/PoolingRestClient.scala 90.90% <0.00%> (+3.03%) ⬆️
...hisk/core/controller/actions/SequenceActions.scala 91.86% <0.00%> (+3.25%) ⬆️
...la/org/apache/openwhisk/common/TransactionId.scala 94.38% <0.00%> (+3.37%) ⬆️
...tainerpool/docker/DockerClientWithFileAccess.scala 96.00% <0.00%> (+4.00%) ⬆️
...sk/core/containerpool/docker/DockerContainer.scala 98.79% <0.00%> (+4.81%) ⬆️
...rg/apache/openwhisk/core/controller/Triggers.scala 94.48% <0.00%> (+4.82%) ⬆️
... and 155 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Scala expert, but the test passes so it must be fine :)

@bdoyle0182
Copy link
Contributor Author

yea this one was an akka nuance. it still has the same expectations so semantic coverage is unchanged

@bdoyle0182 bdoyle0182 merged commit ed43b4d into apache:master Feb 16, 2023
@bdoyle0182 bdoyle0182 deleted the fix-flaky-unit-test branch February 16, 2023 20:01
probe.expectMsgPF() {
case Failure(t) => t.getMessage.contains(s"action version does not match") shouldBe true
}
// next two events can happen in any order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
Co-authored-by: Brendan Doyle <[email protected]>
(cherry picked from commit ed43b4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants