Skip to content

update language runtimes to use newer versions #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

dgrove-oss
Copy link
Member

make a pass through the default runtime.json file to add newer runtime versions and deprecate some variants that are past their language versions EOL dates.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #5381 (3e88e88) into master (f0e281e) will decrease coverage by 9.98%.
The diff coverage is n/a.

❗ Current head 3e88e88 differs from pull request most recent head 608990b. Consider uploading reports for the commit 608990b to get more accurate results

@@            Coverage Diff             @@
##           master    #5381      +/-   ##
==========================================
- Coverage   76.50%   66.53%   -9.98%     
==========================================
  Files         240      240              
  Lines       14569    14569              
  Branches      647      647              
==========================================
- Hits        11146     9693    -1453     
- Misses       3423     4876    +1453     
Impacted Files Coverage Δ
...scala/org/apache/openwhisk/common/time/Clock.scala 0.00% <0.00%> (-100.00%) ⬇️
...nwhisk/core/scheduler/queue/ContainerCounter.scala 0.00% <0.00%> (-100.00%) ⬇️
...hisk/core/scheduler/message/ContainerMessage.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/scheduler/queue/SchedulingDecisionMaker.scala 0.00% <0.00%> (-98.97%) ⬇️
...sk/core/scheduler/container/ContainerManager.scala 0.00% <0.00%> (-95.91%) ⬇️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 0.00% <0.00%> (-82.11%) ⬇️
...scheduler/queue/ElasticSearchDurationChecker.scala 0.00% <0.00%> (-80.77%) ⬇️
...sk/core/scheduler/grpc/ActivationServiceImpl.scala 21.05% <0.00%> (-78.95%) ⬇️
.../main/scala/org/apache/openwhisk/core/WarmUp.scala 21.42% <0.00%> (-78.58%) ⬇️
.../core/scheduler/container/CreationJobManager.scala 0.00% <0.00%> (-77.28%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdoyle0182
Copy link
Contributor

bdoyle0182 commented Feb 15, 2023

LGTM

Making note of this unit test [5]ActivationClientProxyTests. [6]ActivationClientProxy should be closed when the action version does not match seems to be the only real flaky unit test right now at least in the unit tests job whenever we have a chance to look at it

@dgrove-oss
Copy link
Member Author

There's a missing piece. I added a couple new runtime versions and forgot to update the swagger. fixing now...

@bdoyle0182
Copy link
Contributor

bdoyle0182 commented Feb 15, 2023

The standalone tests / system tests may need a look at since I haven't seen those errors before if something in manifest changes could cause those things to fail.

edit: I see you beat me to it

@dgrove-oss dgrove-oss merged commit b7c203b into apache:master Feb 18, 2023
@dgrove-oss dgrove-oss deleted the runtime-currency branch February 18, 2023 00:08
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants