Skip to content

remove action version from scheduler metrics without kamon #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bdoyle0182
Copy link
Contributor

@bdoyle0182 bdoyle0182 commented Nov 30, 2022

Description

Scheduler queue metrics for individual actions generates too many metrics since the action version is included in the metric name currently as a part of the action name. This PR breaks that up so that if kamon tags is not used the action version is not included in the met. Also one fix specifically to the queueActivation metric where the metric name had the namespace twice because the passed in string was $namespace/$action and the full entity path string of $action already includes the namespace.

I've kept it such that the kamon tag will still include the version on the action tag value for now unless that becomes a problem as well.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #5356 (6f5479e) into master (6dd737d) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

❗ Current head 6f5479e differs from pull request most recent head 201d98b. Consider uploading reports for the commit 201d98b to get more accurate results

@@            Coverage Diff             @@
##           master    #5356      +/-   ##
==========================================
- Coverage   76.64%   75.85%   -0.79%     
==========================================
  Files         240      240              
  Lines       14569    14574       +5     
  Branches      647      646       -1     
==========================================
- Hits        11166    11055     -111     
- Misses       3403     3519     +116     
Impacted Files Coverage Δ
...in/scala/org/apache/openwhisk/common/Logging.scala 79.74% <100.00%> (+0.35%) ⬆️
...enwhisk/core/entity/FullyQualifiedEntityName.scala 92.10% <100.00%> (+0.21%) ⬆️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 82.10% <100.00%> (+0.56%) ⬆️
...whisk/connector/kafka/KafkaProducerConnector.scala 56.09% <0.00%> (-24.40%) ⬇️
...whisk/connector/kafka/KafkaConsumerConnector.scala 59.15% <0.00%> (-22.54%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20.00% <0.00%> (-20.00%) ⬇️
...rg/apache/openwhisk/core/controller/Triggers.scala 81.37% <0.00%> (-13.11%) ⬇️
...hisk/core/controller/actions/SequenceActions.scala 82.11% <0.00%> (-9.76%) ⬇️
...sk/core/containerpool/docker/DockerContainer.scala 90.36% <0.00%> (-8.44%) ⬇️
...core/controller/BasicAuthenticationDirective.scala 92.30% <0.00%> (-7.70%) ⬇️
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@style95 style95 closed this Jan 25, 2023
@style95 style95 reopened this Jan 25, 2023
@bdoyle0182 bdoyle0182 closed this Feb 1, 2023
@bdoyle0182 bdoyle0182 reopened this Mar 1, 2023
@bdoyle0182 bdoyle0182 merged commit 96ff327 into apache:master Mar 1, 2023
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
* remove action version from scheduler metrics without kamon

* scalafmt

---------

Co-authored-by: Brendan Doyle <[email protected]>
(cherry picked from commit 96ff327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants