remove action version from scheduler metrics without kamon #5356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scheduler queue metrics for individual actions generates too many metrics since the action version is included in the metric name currently as a part of the action name. This PR breaks that up so that if kamon tags is not used the action version is not included in the met. Also one fix specifically to the
queueActivation
metric where the metric name had the namespace twice because the passed in string was$namespace/$action
and the full entity path string of$action
already includes the namespace.I've kept it such that the kamon tag will still include the version on the action tag value for now unless that becomes a problem as well.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: