Skip to content

Fix typo #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Fix typo #5352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f09c642
Fix typo
style95 Nov 10, 2022
81ed7d5
Fix another typo
style95 Nov 10, 2022
39b7040
Apply scalaFmt
style95 Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/warmed-containers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ case class UserLimits(invocationsPerMinute: Option[Int] = None,
warmedContainerKeepingTimeout: Option[String] = None)
```

So those can be configured in the same way that operators configure the `invocationPerMinute` limit.
So those can be configured in the same way that operators configure the `invocationsPerMinute` limit.

```json
{
"_id": "guest/limits",
"invocationPerMinutes": 10,
"invocationsPerMinute": 10,
"warmedContainerKeepingCount": 8,
"warmedContainerKeepingTimeout": "24 hours"
}
Expand Down
6 changes: 5 additions & 1 deletion tests/src/test/scala/org/apache/openwhisk/core/scheduler/queue/test/QueueManagerTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,11 @@ class QueueManagerTests
val finalFqn = newFqn.copy(version = Some(SemVer(0, 0, 3)))
val finalRevision = DocRevision("3-test-revision")
// simulate the case that action is updated again while fetch it from database
def newGet(store: ArtifactStore[WhiskEntity], docId: DocId, docRevision: DocRevision, fromCache: Boolean, ignoreMissingAttachment: Boolean) = {
def newGet(store: ArtifactStore[WhiskEntity],
docId: DocId,
docRevision: DocRevision,
fromCache: Boolean,
ignoreMissingAttachment: Boolean) = {
if (docRevision == DocRevision.empty) {
Future(convertToMetaData(action.copy(version = SemVer(0, 0, 3)).toWhiskAction.revision(finalRevision)))
} else
Expand Down