Openwhisk action invocation flow diagram #5340
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5340 +/- ##
==========================================
- Coverage 81.66% 76.53% -5.13%
==========================================
Files 240 240
Lines 14313 14313
Branches 610 610
==========================================
- Hits 11689 10955 -734
- Misses 2624 3358 +734 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
|
|
||
| This diagram depicts the steps which take place within Openwhisk when an action is invoked by the user: | ||
|
|
||
|  |
There was a problem hiding this comment.
After an invocation on the invoker side, there is another process for controllers to receive an activation ack.
It would be great to include that part for the blocking invocation.
There was a problem hiding this comment.
@style95 Please check now.
|
Hi, @Rajiv2605. |
README.md
Outdated
|
|
||
| This diagram depicts the steps which take place within Openwhisk when an action is invoked by the user: | ||
|
|
||
|  |
There was a problem hiding this comment.
Seems pre-warm container available? repeated? if prewarm container is not available, it should do cold start
There was a problem hiding this comment.
Please check now.
There was a problem hiding this comment.
@Rajiv2605 , i saw you fixed 👍
README.md
Outdated
|
|
||
| This diagram depicts the steps which take place within Openwhisk when an action is invoked by the user: | ||
|
|
||
|  |
There was a problem hiding this comment.
It might be a little picky, but could you update the step 20?
It would be great to denote that it sends both acknowledgment and results.
There was a problem hiding this comment.
Please check now.
There was a problem hiding this comment.
Why is the Travis CI check failing?
There was a problem hiding this comment.
Not sure the reason but I retriggered the unit test.
|
@ningyougang Can you approve the PR? |
|
What next? |
|
@Rajiv2605 |
|
No I haven’t. What is that? |
|
You need to fill out this form and submit it to the Apache secretary according to this guide. This is a mandatory process for us to accept your contribution work. |
|
Thanks I have mailed them the form, the .asc file and added public key to Ubuntu keyserver. |
|
@Rajiv2605 |
* Openwhisk invocation flow diagram * Update README.md * Delete Openwhisk-diagram.drawio.png * Updated Openwhisk invocation flow diagram * Delete Openwhisk-diagram.drawio.png * Added ack from invoker controller * Delete Openwhisk-diagram.drawio.png * Add files via upload * Update README.md * Delete Openwhisk-flow.png * Add files via upload * Update README.md * Delete Openwhisk-diagram.png * Add files via upload * Update README.md
I have created a flow diagram to depict about what happens in the internals on an action invocation. I would like to contribute it to Openwhisk's README for future reference.
I had struggled a lot to figure this out and had to go through complex codebase and logs. With this diagram, any new developer can easily understand the flow of data and jump start with what they are interested in.