Skip to content

add container and creation ids to memory queue log #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

bdoyle0182
Copy link
Contributor

Description

Include the container and creation ids in the log when queue attempts to stop. Will help with debugging when in memory queue data gets out of sync with etcd or if etcd data hasn't been properly updated. Helps with knowing if the id corresponds to the id in the invoker that failed to make a request to etcd or if that id recovered and another container was lost with regards to tracking in the memory queue

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@bdoyle0182 bdoyle0182 requested a review from style95 September 13, 2022 00:30
@codecov-commenter
Copy link

Codecov Report

Merging #5324 (cf08c3b) into master (138f3d9) will decrease coverage by 76.47%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #5324       +/-   ##
==========================================
- Coverage   81.03%   4.56%   -76.48%     
==========================================
  Files         239     239               
  Lines       14245   14249        +4     
  Branches      594     602        +8     
==========================================
- Hits        11543     650    -10893     
- Misses       2702   13599    +10897     
Impacted Files Coverage Δ
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 0.00% <0.00%> (-83.95%) ⬇️
.../main/scala/org/apache/openwhisk/core/WarmUp.scala 0.00% <0.00%> (-100.00%) ⬇️
...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala 0.00% <0.00%> (-100.00%) ⬇️
...n/scala/org/apache/openwhisk/utils/JsHelpers.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/org/apache/openwhisk/common/Prometheus.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/org/apache/openwhisk/common/time/Clock.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/org/apache/openwhisk/core/FeatureFlags.scala 0.00% <0.00%> (-100.00%) ⬇️
...ala/org/apache/openwhisk/common/ConfigMXBean.scala 0.00% <0.00%> (-100.00%) ⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/openwhisk/common/ConfigMapValue.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 204 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdoyle0182 bdoyle0182 merged commit a1639f0 into apache:master Sep 13, 2022
@bdoyle0182 bdoyle0182 deleted the add-memory-queue-log branch September 13, 2022 02:40
msciabarra pushed a commit to nuvolaris/openwhisk that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants