Clean Up Etcd Worker Actor #5323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5323 +/- ##
==========================================
- Coverage 81.03% 76.71% -4.32%
==========================================
Files 239 240 +1
Lines 14245 14242 -3
Branches 594 616 +22
==========================================
- Hits 11543 10926 -617
- Misses 2702 3316 +614
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
style95
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
@bdoyle0182 Thank you for handling this.
The changes look great to me with a minor nit.
| expectMsg(FinishWork(key)) | ||
| } | ||
|
|
||
| it should "retry request after failure if lease does not exist" in { |
There was a problem hiding this comment.
Can we also add other negative tests for RegisterData and RegisterInitialData?
|
I merging this as-is because my comment is incidental. |
msciabarra
pushed a commit
to nuvolaris/openwhisk
that referenced
this pull request
Nov 23, 2022
* clean up etcd worker actor * revert etcd client local change for unit testing * fix scala 2.13 compilation Co-authored-by: Brendan Doyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't think this is the root of my issue with the scheduler not learning that a container has been removed, but nevertheless this is a valuable refactor to make sure everything is thread safe in this actor.
There should be no behavior change to the actor at all, should be 100% refactor.
This pr does a couple things:
leasefrom future callbacks through 3.Related issue and scope
My changes affect the following components
Types of changes
Checklist: