Skip to content

add config to fail async scheduler throttles as whisk errors #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

bdoyle0182
Copy link
Contributor

Description

The scheduler throttling activations can be asynchronous off the api path so a 429 is not returned to denote a throttle. The user must get the activation and look at why it failed. Action developer errors are generally non-retryable issues whereas whisk errors are usually considered retryable for the user. Though still not a perfect classification this new failure mode probably needs a new status code of throttle type, but that can be done later. This allows you to configure whether you want these errors to be action developer errors or whisk errors

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdoyle0182 bdoyle0182 closed this Sep 1, 2022
@bdoyle0182 bdoyle0182 reopened this Sep 1, 2022
@bdoyle0182 bdoyle0182 merged commit 20a7b1c into apache:master Sep 1, 2022
msciabarra pushed a commit to nuvolaris/openwhisk that referenced this pull request Nov 23, 2022
…5305)

* add config to fail async scheduler throttles as whisk errors

* fix tests

Co-authored-by: Brendan Doyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants