Skip to content

Adjust the default configurations. #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ansible/group_vars/all
Original file line number Diff line number Diff line change
Expand Up @@ -464,11 +464,11 @@ etcd:
dir:
data: "{{ etcd_data_dir | default('') }}"
lease:
timeout: "{{ etcd_lease_timeout | default(1) }}"
timeout: "{{ etcd_lease_timeout | default(10) }}"
loglevel: "{{ etcd_log_level | default('info') }}"
quota_backend_bytes: "{{ etcd_quota_backend_bytes | default(0) }}"
snapshot_count: "{{ etcd_snapshot_count | default(100000) }}"
auto_compaction_retention: "{{ etcd_auto_compaction_retention | default(1) }}"
quota_backend_bytes: "{{ etcd_quota_backend_bytes | default(2147483648) }}" # 2GB
snapshot_count: "{{ etcd_snapshot_count | default(10000) }}"
auto_compaction_retention: "{{ etcd_auto_compaction_retention | default(10m) }}"
auto_compaction_mode: "{{ etcd_auto_compaction_mode | default('periodic') }}"
pool_threads: "{{ etcd_pool_threads | default(10) }}"

Expand Down Expand Up @@ -530,9 +530,9 @@ scheduler:
maxRetriesToGetQueue: "{{ scheduler_maxRetriesToGetQueue | default(13) }}"
queue:
# the queue's state Running timeout, e.g. if have no activation comes into queue when Running, the queue state will be changed from Running to Idle and delete the decision algorithm actor
idleGrace: "{{ scheduler_queue_idleGrace | default('20 seconds') }}"
idleGrace: "{{ scheduler_queue_idleGrace | default('10 minutes') }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As warmed containers are kept for 10 minutes, it's better to keep the queue as well.
It's relatively safer than containers to keep an idle queue as it uses fewer resources when idle.

# the queue's state Idle timeout, e.g. if have no activation comes into queue when Idle, the queue state will be changed from Idle to Removed
stopGrace: "{{ scheduler_queue_stopGrace | default('20 seconds') }}"
stopGrace: "{{ scheduler_queue_stopGrace | default('10 minutes') }}"
# the queue's state Paused timeout, e.g. if have no activation comes into queue when Paused, the queue state will be changed from Paused to Removed
flushGrace: "{{ scheduler_queue_flushGrace | default('60 seconds') }}"
gracefulShutdownTimeout: "{{ scheduler_queue_gracefulShutdownTimeout | default('5 seconds') }}"
Expand Down
4 changes: 4 additions & 0 deletions ansible/roles/schedulers/tasks/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@
"CONFIG_whisk_timeLimit_max": "{{ limit_action_time_max | default() }}"
"CONFIG_whisk_timeLimit_std": "{{ limit_action_time_std | default() }}"

"CONFIG_whisk_concurrencyLimit_min": "{{ limit_action_concurrency_min | default() }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing configuration.

"CONFIG_whisk_concurrencyLimit_max": "{{ limit_action_concurrency_max | default() }}"
"CONFIG_whisk_concurrencyLimit_std": "{{ limit_action_concurrency_std | default() }}"

"RUNTIMES_MANIFEST": "{{ runtimesManifest | to_json }}"
"CONFIG_whisk_runtimes_defaultImagePrefix":
"{{ runtimes_default_image_prefix | default() }}"
Expand Down
7 changes: 7 additions & 0 deletions core/invoker/src/main/resources/application.conf
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,13 @@ whisk {
username: "invoker.user"
password: "invoker.pass"
protocol: http

resource {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are required to run OpenWhisk with other than Ansible.

tags: ""
}
dedicated {
namespaces: ""
}
}
runtime.delete.timeout = "30 seconds"
}