Skip to content

Adjust error for container creation. #5295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

style95
Copy link
Member

@style95 style95 commented Jul 26, 2022

Description

When an action is already updated but activations with an old revision arrive, this error can happen.
It is not supposed to happen in a normal case but it might happen when a cache invalidation issue happens for some reason.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

When an action is already updated but activations with an old revision arrive, this error can happen.
It is not supposed to happen in a normal case but it might happen when a cache invalidation issue happens for some reason.
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #5295 (355b872) into master (f915acc) will increase coverage by 20.12%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #5295       +/-   ##
===========================================
+ Coverage   45.04%   65.16%   +20.12%     
===========================================
  Files         238      238               
  Lines       14179    14179               
  Branches      617      617               
===========================================
+ Hits         6387     9240     +2853     
+ Misses       7792     4939     -2853     
Impacted Files Coverage Δ
...nwhisk/core/invoker/ContainerMessageConsumer.scala 76.59% <0.00%> (+76.59%) ⬆️
...nwhisk/core/scheduler/queue/ContainerCounter.scala 0.00% <0.00%> (-100.00%) ⬇️
...hisk/core/scheduler/message/ContainerMessage.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/scheduler/queue/SchedulingDecisionMaker.scala 0.00% <0.00%> (-98.80%) ⬇️
...sk/core/scheduler/container/ContainerManager.scala 0.00% <0.00%> (-96.90%) ⬇️
.../openwhisk/core/scheduler/FPCSchedulerServer.scala 0.00% <0.00%> (-95.84%) ⬇️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 0.00% <0.00%> (-84.68%) ⬇️
...scheduler/queue/ElasticSearchDurationChecker.scala 0.00% <0.00%> (-80.77%) ⬇️
.../main/scala/org/apache/openwhisk/core/WarmUp.scala 21.42% <0.00%> (-78.58%) ⬇️
...sk/core/scheduler/grpc/ActivationServiceImpl.scala 21.42% <0.00%> (-78.58%) ⬇️
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@style95 style95 merged commit 4912565 into apache:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants