Skip to content

Add retry to store activations. #5277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Add retry to store activations. #5277

merged 1 commit into from
Jul 15, 2022

Conversation

style95
Copy link
Member

@style95 style95 commented Jul 11, 2022

Description

Sometimes, the system fails to store activations for intermittent errors such as network rupture.
It would be great to retry storing them in such a case.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #5277 (3a5c381) into master (639c4a9) will decrease coverage by 17.00%.
The diff coverage is 37.50%.

@@             Coverage Diff             @@
##           master    #5277       +/-   ##
===========================================
- Coverage   80.07%   63.07%   -17.01%     
===========================================
  Files         238      238               
  Lines       14084    14101       +17     
  Branches      588      575       -13     
===========================================
- Hits        11278     8894     -2384     
- Misses       2806     5207     +2401     
Impacted Files Coverage Δ
...che/openwhisk/core/database/CouchDbRestStore.scala 69.60% <33.33%> (-1.61%) ⬇️
...e/elasticsearch/ElasticSearchActivationStore.scala 77.34% <35.71%> (-4.42%) ⬇️
...a/org/apache/openwhisk/core/database/Batcher.scala 95.00% <100.00%> (ø)
...che/openwhisk/core/invoker/LogStoreCollector.scala 0.00% <0.00%> (-100.00%) ⬇️
...nwhisk/core/scheduler/queue/ContainerCounter.scala 0.00% <0.00%> (-100.00%) ⬇️
...hisk/core/scheduler/message/ContainerMessage.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/scheduler/queue/SchedulingDecisionMaker.scala 0.00% <0.00%> (-98.80%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639c4a9...3a5c381. Read the comment docs.

@style95 style95 merged commit 814b7fa into apache:master Jul 15, 2022
@style95 style95 mentioned this pull request Jul 26, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants