-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Bumping to gradle 6 #5276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping to gradle 6 #5276
Conversation
@@ -44,7 +44,7 @@ buildscript { | |||
dependencies { | |||
// see https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle | |||
// for the currently latest version. | |||
classpath 'gradle.plugin.com.lightbend.akka.grpc:akka-grpc-gradle-plugin:0.7.2' | |||
classpath 'com.lightbend.akka.grpc:akka-grpc-gradle-plugin:1.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this handle the annoying akka-grpc plugin logs issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is for resolving compatibility issue with gradle 6.
This PR is for gradle version upgrade only and does not consider any other issues.
The problem you mentioned seems to be fixed in the akka-grpc 2.1.0 version.
I tried to upgrade the version, but the build does not work due to a dependency problem.
It would be better to deal with other PR.
https://github.com/akka/akka-grpc/releases/tag/v2.1.0
akka/akka-grpc#1363
🎉 this is great thank you. |
Codecov Report
@@ Coverage Diff @@
## master #5276 +/- ##
==========================================
- Coverage 80.09% 76.18% -3.92%
==========================================
Files 238 238
Lines 14080 14199 +119
Branches 576 605 +29
==========================================
- Hits 11277 10817 -460
- Misses 2803 3382 +579
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small questions.
Fixed all dependency issues. No code changes and all test code passed, so I'll merge it soon.
|
Description
Reference
Related issue and scope
My changes affect the following components
Types of changes
Checklist: