Skip to content

Forward header from a trigger to actions. #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

style95
Copy link
Member

@style95 style95 commented Jul 9, 2022

Description

This is to forward headers delivered to triggers to actions.
This is useful when an event source sends some information via headers.
A good example could be the X-Github-Event header in Github APIs.

image

Currently, this kind of information is dropped.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #5273 (9afa2a4) into master (639c4a9) will decrease coverage by 14.62%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           master    #5273       +/-   ##
===========================================
- Coverage   80.07%   65.45%   -14.63%     
===========================================
  Files         238      238               
  Lines       14084    14130       +46     
  Branches      588      582        -6     
===========================================
- Hits        11278     9249     -2029     
- Misses       2806     4881     +2075     
Impacted Files Coverage Δ
...rg/apache/openwhisk/core/controller/Triggers.scala 81.37% <88.88%> (+0.35%) ⬆️
...nwhisk/core/scheduler/queue/ContainerCounter.scala 0.00% <0.00%> (-100.00%) ⬇️
...hisk/core/scheduler/message/ContainerMessage.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/scheduler/queue/SchedulingDecisionMaker.scala 0.00% <0.00%> (-98.80%) ⬇️
...sk/core/scheduler/container/ContainerManager.scala 0.00% <0.00%> (-96.90%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
.../openwhisk/core/scheduler/FPCSchedulerServer.scala 0.00% <0.00%> (-95.84%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639c4a9...9afa2a4. Read the comment docs.

@@ -0,0 +1,3 @@
function main(args) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other similar test codes seem to contain apache header.

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.

@style95 style95 merged commit 7c5a5d6 into apache:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants