Skip to content

rework scheduler wait time metric to include total time in scheduler #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

bdoyle0182
Copy link
Contributor

@bdoyle0182 bdoyle0182 commented Jun 8, 2022

Description

The current scheduler wait time metric emits as soon as the queue manager receives an activation. From this point it's then put on to the respective action queue in which it may wait for variable amounts of time until the activation is retrieved by an action container from the queue. The existing wait time metric still exists but is renamed to kafkaWaitTime since it's essentially the wait time from when the transaction starts to when it gets to the scheduler. The new version of waitTime metric emits for an action whenever the action either is force error completed within the memory queue or when the activation is forwarded to an action container and removed from the scheduler queue.

Related issue and scope

N/A

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@bdoyle0182 bdoyle0182 requested a review from style95 June 14, 2022 22:06
Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@style95 style95 merged commit 052d4d2 into apache:master Jun 15, 2022
JesseStutler pushed a commit to JesseStutler/openwhisk that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants