Skip to content

add fpc load balancer metrics #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

bdoyle0182
Copy link
Contributor

@bdoyle0182 bdoyle0182 commented May 21, 2022

Description

Add missing load balancer metrics that previously existed in the old scheduler. Since there is no longer a concept of managed / blackbox to the load balancer, some of the metrics are just all encompassing now and not differentiated by invoker type. This is useful to see how large your invoker fleet currently is that's healthy and unhealthy without having to hit the controller's invoker endpoint and emitting your own status externally. Also added in the completion ack metrics which were also missing

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #5240 (d3a6a9a) into master (3e3414c) will increase coverage by 29.82%.
The diff coverage is 40.90%.

@@             Coverage Diff             @@
##           master    #5240       +/-   ##
===========================================
+ Coverage   44.53%   74.36%   +29.82%     
===========================================
  Files         238      238               
  Lines       13957    13990       +33     
  Branches      570      569        -1     
===========================================
+ Hits         6216    10403     +4187     
+ Misses       7741     3587     -4154     
Impacted Files Coverage Δ
.../openwhisk/core/loadBalancer/FPCPoolBalancer.scala 32.95% <27.77%> (-0.79%) ⬇️
...in/scala/org/apache/openwhisk/common/Logging.scala 79.01% <100.00%> (+4.01%) ⬆️
...whisk/connector/kafka/KafkaConsumerConnector.scala 59.15% <0.00%> (-22.54%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20.00% <0.00%> (-20.00%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 60.97% <0.00%> (-19.03%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 54.33% <0.00%> (-18.90%) ⬇️
...apache/openwhisk/core/ack/MessagingActiveAck.scala 58.33% <0.00%> (-8.34%) ⬇️
.../core/scheduler/container/CreationJobManager.scala 83.07% <0.00%> (-0.26%) ⬇️
...sk/core/scheduler/container/ContainerManager.scala 88.60% <0.00%> (-0.12%) ⬇️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3414c...d3a6a9a. Read the comment docs.

@bdoyle0182 bdoyle0182 requested a review from style95 May 21, 2022 03:24
@bdoyle0182 bdoyle0182 merged commit 426aef4 into apache:master May 24, 2022
JesseStutler pushed a commit to JesseStutler/openwhisk that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants