Skip to content

Add missing configuration for scheduler #5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2022

Conversation

upgle
Copy link
Member

@upgle upgle commented May 13, 2022

Description

The configuration for running the scheduler is missing, so I added the configuration.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #5235 (1d27143) into master (37f1f99) will increase coverage by 46.92%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master    #5235       +/-   ##
===========================================
+ Coverage   26.29%   73.22%   +46.92%     
===========================================
  Files         238      238               
  Lines       13965    13964        -1     
  Branches      576      571        -5     
===========================================
+ Hits         3672    10225     +6553     
+ Misses      10293     3739     -6554     
Impacted Files Coverage Δ
...apache/openwhisk/connector/lean/LeanProducer.scala 0.00% <0.00%> (ø)
.../org/apache/openwhisk/core/connector/Message.scala 76.28% <ø> (+34.02%) ⬆️
...enwhisk/core/loadBalancer/InvokerSupervision.scala 90.27% <0.00%> (+90.27%) ⬆️
...e/loadBalancer/ShardingContainerPoolBalancer.scala 78.53% <ø> (+78.53%) ⬆️
...ontainerpool/v2/FunctionPullingContainerPool.scala 80.32% <ø> (+80.32%) ⬆️
...nwhisk/core/invoker/ContainerMessageConsumer.scala 78.72% <ø> (+78.72%) ⬆️
...he/openwhisk/core/invoker/FPCInvokerReactive.scala 0.00% <ø> (ø)
...whisk/connector/kafka/KafkaProducerConnector.scala 80.48% <100.00%> (+20.48%) ⬆️
...enwhisk/core/loadBalancer/CommonLoadBalancer.scala 71.42% <100.00%> (+71.42%) ⬆️
.../openwhisk/core/loadBalancer/FPCPoolBalancer.scala 33.73% <100.00%> (+33.73%) ⬆️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdcfe5...1d27143. Read the comment docs.

@style95 style95 merged commit 6731f1c into apache:master May 26, 2022
JesseStutler pushed a commit to JesseStutler/openwhisk that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants