Skip to content

Take revision into consideration when choose warm container #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2022

Conversation

jiangpengcheng
Copy link
Contributor

Description

Need to compare the revision when choose warmed container

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #5233 (d88a7d2) into master (d88a7d2) will not change coverage.
The diff coverage is n/a.

❗ Current head d88a7d2 differs from pull request most recent head ad4d380. Consider uploading reports for the commit ad4d380 to get more accurate results

@@           Coverage Diff           @@
##           master    #5233   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files         238      238           
  Lines       13965    13965           
  Branches      578      578           
=======================================
  Hits        11083    11083           
  Misses       2882     2882           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88a7d2...ad4d380. Read the comment docs.

@jiangpengcheng jiangpengcheng force-pushed the fix_warmed_container_choosen branch from 031b988 to ad4d380 Compare May 20, 2022 04:29
@style95 style95 merged commit 7fdc246 into apache:master May 24, 2022
JesseStutler pushed a commit to JesseStutler/openwhisk that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants