Skip to content

don't log a uuid of the username portion of basic auth info #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

dgrove-oss
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #5142 (175c13b) into master (bf62f74) will increase coverage by 30.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5142       +/-   ##
===========================================
+ Coverage   43.88%   74.79%   +30.91%     
===========================================
  Files         231      231               
  Lines       12807    12806        -1     
  Branches      528      503       -25     
===========================================
+ Hits         5620     9578     +3958     
+ Misses       7187     3228     -3959     
Impacted Files Coverage Δ
...core/controller/BasicAuthenticationDirective.scala 53.84% <ø> (+53.84%) ⬆️
...whisk/connector/kafka/KafkaProducerConnector.scala 60.00% <0.00%> (-27.50%) ⬇️
...whisk/connector/kafka/KafkaConsumerConnector.scala 59.15% <0.00%> (-22.54%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20.00% <0.00%> (-20.00%) ⬇️
...pache/openwhisk/core/containerpool/Container.scala 89.65% <0.00%> (-1.15%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 79.31% <0.00%> (ø)
.../org/apache/openwhisk/core/entity/EntityPath.scala 100.00% <0.00%> (+1.88%) ⬆️
...la/org/apache/openwhisk/common/TransactionId.scala 94.38% <0.00%> (+2.24%) ⬆️
.../org/apache/openwhisk/http/PoolingRestClient.scala 90.90% <0.00%> (+3.03%) ⬆️
...sk/core/containerpool/docker/DockerContainer.scala 95.60% <0.00%> (+3.29%) ⬆️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf62f74...175c13b. Read the comment docs.

@dgrove-oss dgrove-oss merged commit 4e25ada into apache:master Jul 21, 2021
@dgrove-oss dgrove-oss deleted the no-log-auth branch July 21, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants