Skip to content

Fix wsk action create command in Rust example #5056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

kingledion
Copy link
Contributor

@kingledion kingledion commented Jan 27, 2021

The command given wsk action create helloRust hello.rs does not work as given, yielding an error message. This can be corrected by specifying the action type via --kind rust:1.34

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

The command given `wsk action create helloRust hello.rs` does not work as given, yielding an error message. This can be corrected by specifying the action type via `--kind rust:1.34`
@kingledion
Copy link
Contributor Author

This issue will be resolved by this fix: https://github.com/apache/openwhisk/issues/5055

@style95
Copy link
Member

style95 commented Jan 27, 2021

@kingledion
Thank you for the first contribution.

While this change would do its bit, I think the main issue is CLI does not infer the kind automatically.
And I confirmed that .rs extension is not considered in CLI.
https://github.com/apache/openwhisk-cli/blob/master/commands/action.go#L58

Do you have an interest in fixing the CLI instead?

@rabbah
Copy link
Member

rabbah commented Jan 28, 2021

I propose we can accept this doc update until the cli is patched.

@dgrove-oss
Copy link
Member

Agreed; let's update the docs with the workaround, fix the cli, release the cli, then revert the doc update.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@dgrove-oss
Copy link
Member

cli issue: apache/openwhisk-cli#494

@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #5056 (6deebb5) into master (6686820) will decrease coverage by 6.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5056      +/-   ##
==========================================
- Coverage   82.35%   75.61%   -6.74%     
==========================================
  Files         206      199       -7     
  Lines       10006     9741     -265     
  Branches      445      442       -3     
==========================================
- Hits         8240     7366     -874     
- Misses       1766     2375     +609     
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
...ore/database/azblob/AzureBlobAttachmentStore.scala 11.53% <0.00%> (-60.58%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6686820...6deebb5. Read the comment docs.

@rabbah rabbah merged commit 212d809 into apache:master Jan 29, 2021
@rabbah
Copy link
Member

rabbah commented Jan 29, 2021

Thank you @kingledion 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants