Fixes bug in invoker supervision on startup. #5050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
force-pushed
the
invoker-health
branch
from
3f65d78 to
dd13ada
Compare
rabbah
commented
Jan 24, 2021
| gotoIfNotThere(Unresponsive) | ||
| } else { | ||
| gotoIfNotThere(Healthy) | ||
| result match { |
There was a problem hiding this comment.
The changes above are comments and semantically preserving refactoring for clarity. The substance of the PR is in the following case statements on lines 409, 413 and 417.
Codecov Report
@@ Coverage Diff @@
## master #5050 +/- ##
==========================================
- Coverage 81.41% 75.62% -5.79%
==========================================
Files 199 199
Lines 9735 9741 +6
Branches 435 442 +7
==========================================
- Hits 7926 7367 -559
- Misses 1809 2374 +565
Continue to review full report at Codecov.
|
rabbah
force-pushed
the
invoker-health
branch
from
dd13ada to
4d55a36
Compare
style95
approved these changes
Jan 25, 2021
rabbah
force-pushed
the
invoker-health
branch
from
4d55a36 to
5d6e045
Compare
|
LGTM glad this got caught |
bdoyle0182
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The invoker health supervisor, on startup, eagerly went into the health state without confirming the test action was actually successful. This happens at startup, when the ring buffer is not yet primed. The patch herein adjusts the health protocol for the priming phase and stays unhealth/unresponsive if the test action failed.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: