Skip to content

feat(core): support sharing one redb database between different Operators #6173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2025

Conversation

TD-Sky
Copy link
Contributor

@TD-Sky TD-Sky commented May 12, 2025

Which issue does this PR close?

Closes #6172 .

What changes are included in this PR?

  • RedbBuilder::database(self, db: &Arc<redb::Database>) -> Self
  • Creating the specified table at build stage if it doesn't exist (It's really important because trying to get something in table is a common need, but errors will occur when the table doesn't exist)

Are there any user-facing changes?

  • Users got a new method: opendal::services::Redb::database(self, db: &Arc<redb::Database>) -> Self
  • (breaking change) OperatorInfo::name for redb become table name instead of datadir.

@TD-Sky TD-Sky requested a review from Xuanwo as a code owner May 12, 2025 05:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 12, 2025
@TD-Sky TD-Sky changed the title feat(core): share one redb database between different Operators feat(core): support sharing one redb database between different Operators May 12, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 13, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 13, 2025
@Xuanwo Xuanwo merged commit 9980484 into apache:main May 13, 2025
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new feature: support multi-tables access for redb
2 participants